New Group Member Default Setting Not Working with Memberpress

  • Strothi

    (@strothi)


    5 years, 2 months ago

    Dear @boonebgorges,

    I hope I find you well. I realized today that I’ve an issue with new group members and the standard email setting when joining. It works perfectly fine when users join themselves.

    I however do have the special case that I’m using Memberpress to manage my members and add them automatically to a group just reserved for them. When Memberpress does add members to the group (see here), the setting for email frequency is probably not being triggered and thus new members always get “All Email”.

    I realize that this is a special case, but I was wondering whether this could maybe be addressed as part of the rewrite of the plugin or whether you have an idea how to address it already now? 🙂

    Either way, thanks so much in advance and I really appreciate all your work!

    Kind regards, Philip

Viewing 12 replies - 1 through 12 (of 12 total)
  • Plugin Author Boone Gorges

    (@boonebgorges)

    5 years, 2 months ago

    Hi @strothi – Sorry for the trouble.

    I’m afraid I’m unable to provide support for paid plugins like Memberpress.

    It’s likely that Memberpress is adding users to the group in a way that doesn’t trigger the BPGES hook for some reason. Here’s the relevant code in BPGES: https://github.com/boonebgorges/buddypress-group-email-subscription/blob/3.8.x/bp-activity-subscription-functions.php#L1258 You may be able to pass this along to the Memberpress folks to see if they can pinpoint the issue in their plugin.

    Thread Starter Strothi

    (@strothi)

    5 years, 2 months ago

    Ok great, thanks. I’ll see whether the Memberpress guys can help 🙂

    Kind regards, Philip

    Thread Starter Strothi

    (@strothi)

    5 years, 2 months ago

    Dear @boonebgorges,

    I hope I find you well. The memberpress support got back to me with a revised file to test. Unfortunately it still doesn’t work and now they were wondering whether you could be so kind and have a look as to what might be wrong.

    The file in question is the following: https://www.dropbox.com/s/s65r49d7pl754i8/MpBuddyPress.php?dl=0

    He says he’s doing a do_action call as requested, but as I said, it doesn’t work so far.

    I would be really really grateful if you could look into this and point us in the right direction. Thanks so much in advance and have a nice weekend 🙂

    Kind regards, Philip

    Plugin Author Boone Gorges

    (@boonebgorges)

    5 years, 2 months ago

    Thanks for sharing. The do_action() code added here should not be necessary; by calling groups_join_group(), the necessary action should be fired deeper in BuddyPress.

    Since group-member adding is in fact working, I’m guessing that there’s a load order issue. For example, the ‘mepr-event-create’ action triggers group-membership syncing actions. But if this action fires before BPGES has a chance to load its libraries, it wouldn’t be able to detect the change. Specifically, BP-related code should load at least after ‘bp_include’; see eg https://github.com/boonebgorges/buddypress-group-email-subscription/blob/71f697ca87df67fbbc6dd10712e5e66f9f6435c6/bp-activity-subscription.php#L42

    Thread Starter Strothi

    (@strothi)

    5 years, 2 months ago

    Thanks so much, I really appreciate it!!! I will forward your message 🙂

    Kind regards, Philip

    cartpauj

    (@cartpauj)

    5 years, 2 months ago

    I don’t think MemberPress runs any events before “init” which is after “plugins_loaded” has executed. How late does BPGES load?

    Thread Starter Strothi

    (@strothi)

    5 years, 2 months ago

    Dear Boone,

    meet Paul, the developer with whom I’ve been in touch on the Memberpress side of things. I hope you guys can work this out together and thought it would be easier by connecting you directly 🙂

    Thanks so much in advance, really appreciate it!

    Kind regards, Philip

    Plugin Author Boone Gorges

    (@boonebgorges)

    5 years, 2 months ago

    Hi @cartpauj – BPGES loads its add_action() hooks at ‘bp_include’, which fires on ‘bp_loaded’ at priority 4; ‘bp_loaded’ loads at ‘plugins_loaded’ with priority 10. If MP is adding members to BP groups at plugins_loaded:10 or earlier, it could result in a load-order issue.

    Are you able to reproduce the problem that @strothi has described, or is it specific to his setup?

    If someone can pass me a copy of MemberPress (my username at gmail dot com) and give me brief instructions on how to configure it so as to reproduce the issue, it’s likely that I could identify the problem.

    cartpauj

    (@cartpauj)

    5 years, 2 months ago

    No events run before “init” that I’m aware of.

    Thread Starter Strothi

    (@strothi)

    5 years, 2 months ago

    Dear both,

    I hope I find you well and wanted to check whether there’s been some progress? Thanks for offering to look through the code yourself @boonebgorges. @cartpauj, did you provide a copy of memberpress to him so he can have a look?

    Kind regards, Philip

    Thread Starter Strothi

    (@strothi)

    5 years, 2 months ago

    Dear @boonebgorges,

    to move things forward, I’ve set up a test environment for you. I just sent you an email with the login data 🙂

    Thanks so much in advance!

    Kind regards, Philip

    Plugin Author Boone Gorges

    (@boonebgorges)

    5 years, 1 month ago

    Thanks for your patience as I looked into this.

    It’s a bug in BPGES, albeit one that arises only when coupled with MemberPress (for reasons I didn’t bother to look deeply into).

    Technical description is here: https://github.com/boonebgorges/buddypress-group-email-subscription/issues/168 It will be fixed as part of the upcoming 3.9.0 release of BPGES. Philip, the patch is in place on the test site whose credentials you sent to me.

Viewing 12 replies - 1 through 12 (of 12 total)
  • The topic ‘New Group Member Default Setting Not Working with Memberpress’ is closed to new replies.