Needs some fixes

  • Kchun

    (@kchun)


    8 years, 11 months ago

    Either use get_stylesheet_directory_uri() instead of get template directory uri to load main.js and several other files or fix main.js thusly:

    if ( scroll > nav.outerHeight()-12 ) {
			nav.addClass( 'scrolled' );

    (add the -12 because it isn’t scrolling until the menu is partially over the content div)

    Since cover is given a z-index all of the divs need a z-index to avoid jiggling while scrolling in IE

    If content exceeds 500 pixels in height the bottom of the screen has no background.

    But it is a cool idea.

Viewing 6 replies - 1 through 6 (of 6 total)
  • Theme Author Felynx

    (@felynx)

    8 years, 11 months ago

    Hello Kchun,

    Thank you for your review. I’ll use the function you recommended for the next update.

    Concerning the jiggling and the lack of background can you tell me the version of IE and the website you observe these bugs so I can reproduce them?

    Thread Starter Kchun

    (@kchun)

    8 years, 11 months ago

    Thank you so much! Really like your theme.

    Jiggling was reported by client and I can’t see it either.

    Here’s another request: in the green.css, blue.css etc file when you load the googleapis files could you change to:

    @import url(//fonts.googleapis.com/css?family=Raleway:100,300);

    That way if we’re using https (which google wants us to) it will fetch https://fonts.googleapis.com… or http://… if the site is not using SSL.

    We have naive customers using IE and getting warnings about insecure content when @import url(http://fonts.googleapis.com/css?family=Raleway:100,300); is loaded.

    Theme Author Felynx

    (@felynx)

    8 years, 11 months ago

    Thanks to you. 🙂

    Indeed for the import you’re right, I fix this. I’ll push the updates quickly.

    For the IE bugs, if you have a site client to show me I’ll investigate further.

    Thread Starter Kchun

    (@kchun)

    8 years, 11 months ago

    Should the submenus show when the menu gets small on a phone??

    Theme Author Felynx

    (@felynx)

    8 years, 11 months ago

    No, for now I preferred simplicity for the mobile version menu.

    Theme Author Felynx

    (@felynx)

    8 years, 10 months ago

    Hello Kchun,

    The 2.4 version is now available with use of get_stylesheet_directory_uri() and the fix of the google font @import.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Needs some fixes’ is closed to new replies.