WordPress.org

Resolved casbboy
(@casbboy)

5 months ago

If you go to the amp page, you will see the logo up top that should take you back to hom.

It’s not, it’s taking to a page that doesn’t exist since it is leaving off the trailing “/” that should be there.

How can I get it to add a slash?

Cheers!
Ryan

The page I need help with: [log in to see the link]

Viewing 5 replies - 1 through 5 (of 5 total)

Plugin Support Ryan Kienstra
(@ryankienstra)

5 months ago
Hi @casbboy,
Thanks for bringing this up. I also saw that issue.

It might be that we need to change the plugin to use home_url( '/' ) instead of home_url():

https://github.com/Automattic/amp-wp/blob/c65cbf85d0110620c0fcb29c3db12348f2aa1df3/includes/templates/class-amp-post-template.php#L116

It looks like the default use of that function is:
```
<?php echo esc_url( home_url( '/' ) ); ?>
```
I’ll let you know about this, and feel free to also ping me on this topic.
Plugin Support Ryan Kienstra
(@ryankienstra)

5 months ago
Workaround

In the meantime, here’s a workaround to add the trailing slash. You can add this to a theme or plugin:
```
/**
 * Ensure the home url has a trailing slash.
 *
 * @param array $data The AMP post template data.
 * @return array $data The filtered AMP post template data.
 */
add_filter( 'amp_post_template_data', function( $data ) {
	if ( isset( $data['home_url'] ) ) {
		$data['home_url'] = home_url( '/' );
	}
	return $data;
} );
```
Plugin Support Ryan Kienstra
(@ryankienstra)

5 months ago

Here’s the GitHub issue, in case you’d like to see the status of a possible fix:
https://github.com/Automattic/amp-wp/issues/1158

casbboy
(@casbboy)

5 months ago

That did the trick!

Thanks

Plugin Support Ryan Kienstra
(@ryankienstra)

5 months ago

Hi @casbboy,
Sure, we’re planning on releasing the fix from the GitHub PR above as part of 0.7.1 this coming week.

Viewing 5 replies - 1 through 5 (of 5 total)

You must be logged in to reply to this topic.

In: Plugins
5 replies
2 participants
Last reply from: Ryan Kienstra
Last activity: 5 months ago
Status: resolved

Views