Multiple Missing Closing Tags in Markup

  • Resolved maxxskywalker

    (@maxxskywalker)


    4 years, 7 months ago

    I’ve noticed your plugin has missing closing anchor tags, within the “recentlyviewed_left” containers, in all of your loop items. After breaking down your shortcode’s markup I’ve found that all of the loop items are reflecting this mistake, messing up any other containers that come after it. You are also missing a closing unordered list tag, and a closing div tag as well.

    My workaround, at this point in time, has been to apply a closing div right after your shortcode so that the rest of my own markup is not affected by your development team’s oversight — I shouldn’t have to do this.

    Please review your markup and update your plugin. I’d rather not have to utilize a different plugin if I don’t have to, but I can’t rollout into production with oversights that stick out this bad.

    Attached is the markup breakdown that has been unaltered from the output, aside from a couple comments and whitespacing cleanup so you can clearly see your missing tags.

    https://drive.google.com/open?id=1MU9AI-7tP4jmsi-XIcTk-HTi4maAJVXI

    The page I need help with: [log in to see the link]

Viewing 15 replies - 1 through 15 (of 24 total)
1 2
  • Plugin Author Amit Sonkhiya

    (@amitaits)

    4 years, 7 months ago

    Hello @maxxskywalker

    Thanks for reaching us and pointing out the issue. We’ve received your email as well. We will check the markup again and fix it sooner. There was a short delay yet due to some issue at our end.

    Thanks again.

    Thread Starter maxxskywalker

    (@maxxskywalker)

    4 years, 7 months ago

    Awesome. Thank you very much for responding to my request. I look forward to the fix.

    • This reply was modified 4 years, 7 months ago by maxxskywalker.
    Plugin Author Amit Sonkhiya

    (@amitaits)

    4 years, 7 months ago

    Hello @maxxskywalker

    We’ve checked the markup in plugin files and couldn’t find any anchor, div or list unclosed. Further, we also visited the linked page but couldn’t find any other page to visit, create the list and check the widget markup back on the linked page.

    Can you please inform the exact page where the plugin is added as well as a few other pages to visit and discover the markup on the given exact page.

    Thanks

    Plugin Author Amit Sonkhiya

    (@amitaits)

    4 years, 7 months ago

    Ok,

    We’ve visited the following 3 URLs:
    https://equipment.almost.online/products/alfa-laval-votator-size-6-x-9-horizontal/
    https://equipment.almost.online/products/fmc-foodtech-stein-breader/
    https://equipment.almost.online/products/alfa-laval-contherm-heat-exchanger-md-6×9/

    And further checked the widget markup on the last one link. Here is the markup after viewing the page source:

    <ul class="recentviewed_post">
    <li>
        <div class="recentviewed_left" style="width:402px;height:242px;">
            <a href="https://equipment.almost.online/products/alfa-laval-votator-size-6-x-9-horizontal/">
                <img width="323" height="242" src="data:image/svg+xml,%3Csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%20323%20242'%3E%3C/svg%3E" class="attachment-402x242 size-402x242 wp-post-image" alt="" data-lazy-src="https://equipment.almost.online/wp-content/uploads/2019/08/alfa-laval-15332.jpg" />
                <noscript><img width="323" height="242" src="https://equipment.almost.online/wp-content/uploads/2019/08/alfa-laval-15332.jpg" class="attachment-402x242 size-402x242 wp-post-image" alt="" /></noscript>
            </a>
        </div>
        <div class="recentviewed_right">
            <a href="https://equipment.almost.online/products/alfa-laval-votator-size-6-x-9-horizontal/">
									Alfa Laval Votator, Size 6×9, Horizontal                                </a>
        </div>
    </li>
    <li>
        <div class="recentviewed_left" style="width:402px;height:242px;">
            <a href="https://equipment.almost.online/products/fmc-foodtech-stein-breader/">
                <img width="323" height="242" src="data:image/svg+xml,%3Csvg%20xmlns='http://www.w3.org/2000/svg'%20viewBox='0%200%20323%20242'%3E%3C/svg%3E" class="attachment-402x242 size-402x242 wp-post-image" alt="" data-lazy-src="https://equipment.almost.online/wp-content/uploads/2019/09/fmc-breader-xl34.jpg" />
                <noscript><img width="323" height="242" src="https://equipment.almost.online/wp-content/uploads/2019/09/fmc-breader-xl34.jpg" class="attachment-402x242 size-402x242 wp-post-image" alt="" /></noscript>
            </a>
        </div>
        <div class="recentviewed_right">
            <a href="https://equipment.almost.online/products/fmc-foodtech-stein-breader/">
									FMC Foodtech/Stein Breader                                </a>
        </div>
    </li>
</ul>

    The markup is valid and syntitically correct. Do let us know if there is any other concern.

    Thread Starter maxxskywalker

    (@maxxskywalker)

    4 years, 7 months ago

    It looks as if I’m mistaken about the closing anchor tags, but upon further investigation within the page source I’m still noticing a missing closing unordered list tag and closing div tag for your primary parent. Even the page source is throwing a red flag on your missing markup, as seen in the screenshot:

    https://drive.google.com/file/d/1ohqd67emfu78WkWiAslL4_2J_yhi3C5E/view?usp=sharing

    I tested your plugin both with the theme I’m using for my client’s site (Divi) and with an unaltered Twenty Nineteen theme. The markup results are the same.

    I also validated my markup without your plugin, and found that everything I’m doing is correctly closed off.

    I have noticed that the inspector tries to close off missing closing tags, which doesn’t help with discovering missing markup. There is definitely some derivation between the markup shown in the inspector versus the page source view.

    Plugin Author Amit Sonkhiya

    (@amitaits)

    4 years, 7 months ago

    Hello @maxxskywalker

    Can you add this code below after line number 200 in the plugin file recent_viewed_posts.php and tell the output?

    echo 'Post Count: '.$count;

    Also, use the original plugin code without any customization.

    • This reply was modified 4 years, 7 months ago by Amit Sonkhiya.
    Thread Starter maxxskywalker

    (@maxxskywalker)

    4 years, 7 months ago

    I’ve isolated your plugin in a test.php file on my website, to get the purest result possible, found here:
    https://equipment.almost.online/test.php

    Here’s the markup that’s printing out in the page source view:
    https://drive.google.com/open?id=1p6BAPtJVM4ykIhjn1nKm2BYm7c7NPfTs

    I visited four products (since that’s my imposed limit from the widget settings), and as you can see the markup is missing that closing div and ul.

    I placed your echo string within the recent_viewed_posts.php file as seen here:
    https://drive.google.com/open?id=1pFYILDuaaLRmI_stmPf7MS-jQuiEpUp9

    For whatever reason, the echo is not printing out a value, either in my test document or the frontend WordPress product page. You can check now, as I left the echo string in the php document.

    Plugin Author Amit Sonkhiya

    (@amitaits)

    4 years, 7 months ago

    Hello @maxxskywalker

    I’ve checked the markup you provided and see that it is missing the closing ul as well as after widget div. I’m more wondering why isn’t it output

    Post Count

    text even.

    Additionally, with this inspection, I found no missing closing tag.

    Without any further FTP access to your site, I’m feeling helpless to rectify the concern.

    Thread Starter maxxskywalker

    (@maxxskywalker)

    4 years, 7 months ago

    How can I make a private message without opening my site up to ne’er-do-wellers? If anything, I can make a Duplicator package for you to look at in a local environment. Either way, I wouldn’t have a problem giving you access to my staging environment.

    Plugin Author Amit Sonkhiya

    (@amitaits)

    4 years, 7 months ago

    Hello @maxxskywalker

    Currently, I’m traveling out of the state. In the next week, I will be back. You can provide staging environment access in the email as you previously mailed us.

    Thanks

    Thread Starter maxxskywalker

    (@maxxskywalker)

    4 years, 7 months ago

    Sent you that email.

    Plugin Author Amit Sonkhiya

    (@amitaits)

    4 years, 7 months ago

    Hello @maxxskywalker

    We didn’t receive the email. Can you please resend that?

    Thread Starter maxxskywalker

    (@maxxskywalker)

    4 years, 7 months ago

    I replied to the email you sent me from contact@astech.solutions If this email is not monitored, I can fill out the form on your website again. I just figured it would be simplest to reply to that email.

    Regardless, I had forgotten to give you FTP credentials anyway, so I’ll need to create another secret.

    Plugin Author Amit Sonkhiya

    (@amitaits)

    4 years, 6 months ago

    Hi @maxxskywalker

    I did access the site. However, I couldn’t find the widget placed on any product page given in this comment, which was there at the last time.

    Please, put the widget/sidebar somewhere in the product pages and provide me the link.

    Additionally, if you’re on skype or any other messaging channel, do let me know in an email. I’m intended to check the issue within 24 hours.

    Thanks

    Thread Starter maxxskywalker

    (@maxxskywalker)

    4 years, 6 months ago

    I’m using Toolset to manage my layouts for single product pages and archives. If you go over to the left sidebar and locate “Toolset”, there is an option labeled “Layouts” nested under it. From there, simply select the “Layout for Products”, and you will find your shortcode in the cell labeled “Recently Viewed Products”.

    If you want to find that file that I used to isolate your shortcode output, you can find it at this path outside of WordPress: /public_html/equipment/test.php

    Hope this helps.

Viewing 15 replies - 1 through 15 (of 24 total)
1 2
  • The topic ‘Multiple Missing Closing Tags in Markup’ is closed to new replies.