Recent updates to WP are causing MS to make the admin panel crash (“There has been a serious error”), while the plugin itself continues to function. The content seen on the admin page is what looks to be an ad for MS-Pro, which I suppose is being shoved into the header of admin panel pages: this ad is causing the panel to crash.
This topic was modified 1 year, 3 months ago by hmcnally.
Same problem here. My “your site is experiencing a technical issue” email came at 4am today and included this:
An error of type E_ERROR was caused in line 232 of the file /home/irss3rdf/public_html/wp-content/plugins/master-slider/admin/includes/msp-admin-functions.php. Error message: Uncaught TypeError: Unsupported operand types: string / int in /home/irss3rdf/public_html/wp-content/plugins/master-slider/admin/includes/msp-admin-functions.php:232
Stack trace:
#0 /home/irss3rdf/public_html/wp-content/plugins/master-slider/admin/views/slider-panel/index.php(200): msp_get_pro_users_num()
#1 /home/irss3rdf/public_html/wp-content/plugins/master-slider/admin/views/index.php(46): include('/home/irss3rdf/p...')
#2 /home/irss3rdf/public_html/wp-content/plugins/master-slider/admin/class-master-slider-admin.php(223): include_once('/home/irss3rdf/p...')
#3 /home/irss3rdf/public_html/wp-includes/class-wp-hook.php(310): Master_Slider_Admin->display_master_slider_panel_page('')
#4 /home/irss3rdf/public_html/wp-includes/class-wp-hook.php(334): WP_Hook->apply_filters('', Array)
#5 /home/irss3rdf/public_html/wp-includes/plugin.php(517): WP_Hook->do_action(Array)
#6 /home/irss3rdf/public_html/wp-admin/admin.php(259): do_action('toplevel_page_m...')
@matt6303 Thanks for the error dump; I wasn’t seeing it in my case. “When in doubt, comment it out”… I commented out lines 231 and 232 of msp-admin-functions.php and it restored (seemingly) full function. YMMV. Turn off “auto update” on the plugin for obvious reasons if this works.
/**
* Get the number of PRO users
*
* @return int
*/
function msp_get_pro_users_num(){
// $download_num = msp_api_stats_shortcode( array( 'item-id' => '7467925', 'item-param' => 'sales_number', 'cache_in_minutes' => 1200 ) );
// return number_format_i18n( floor( ($download_num/1000) ) * 1000 ). '+';
}
I just checked a 2nd site that didn’t send me an automated error, but it also has the same problem. Here’s a screen capture of what I get immediately upon logging into wp-admin.
@hmcnally Thank you for your fix. I’ve applied that on all 4 of my sites that use Master Slider and it seems to have taken care of it for now. My screenshot above was for others, to confirm this is the problem we’re addressing.
@matt6303 Your screendump was exactly what I was seeing. The code I commented out seems to be acquiring some sort of number about sales (who knows)–it’s evidently OK if that number is zero ;). I bet the sales pitch copy says “join the [number of people] who have bought the Pro version”… and it’s crashing when acquiring/converting that number.
Note to developers: when you shove a sales pitch for your pro-level product into your base-level product, make sure it doesn’t crash the site of the potential customer.
This reply was modified 1 year, 3 months ago by hmcnally.
@hmcnally I have the same issue here but I’m not following how you fixed it. Could you explain more how to do it? Where to add this line? Thanks in advance.
This reply was modified 1 year, 3 months ago by nadaatef.
> I commented out lines 231 and 232 of msp-admin-functions.php
@nadaatef It involves editing the actual code found in one of the plug-in files. That single line is a full explanation. Other people got it. To be blunt, if you didn’t follow what I did, you probably shouldn’t try it yourself. And I won’t provide a .ZIP file of the modded plugin either: this is totally DIY, and I don’t want to run the risk of messing up anyone else’s WP life. Maybe the developer will read this and provide a sanctioned update.
…it’s down. If the plugin is getting the “number of people who went pro” number from something on the site, it’s consistent with the problem (no site, no number to get). Not confidence building for the future of this plugin.
This reply was modified 1 year, 3 months ago by hmcnally.
This reply was modified 1 year, 3 months ago by hmcnally.
I’m not as sophisticated as you guys, so I got my tech guy to disable all plugins so we could get in and delete MS, at least on our staging site. We don’t want to take our church site down until tonight. Hoping it’s all fixed before then. Averta has responded to my text on their Facebook page so is *hopefully* looking at the issue.
“Hi sir, thanks for letting us know. we are working on this and it will be fixe in a few hours
please accept our apologize”
Their site appears up now, maybe it’s fixed without commenting those two lines. Another user in this forum actually edited a line vs. commenting it out, which may be a solution but since these lines appear to be returning a non-critical number (people who have bought the pro version), I hope the developer, if they’re still around, just nukes that part of their header’s sales pitch. It should never rely on data from another source.
