More than one GeoJSON popup_property

That might be a hard one (but might not).

I like the idea of string formatting as you suggest; maybe something like:

[leaflet-geojson]
{title}
[/leaflet-geojson]

You could do something like that in leaflet-map/shortcodes/class.geojson-shortcode.php

The function reads like this:

function onEachFeature (feature, layer) {
    var props = feature.properties || {},
        text = popup_property && props[ popup_property ] || popup_text;
    if (text) {
        layer.bindPopup( text );
    }
}

Leaflet actually has a function to interpolate strings, called L.Util.template. So you should be able to change the function like this:

function onEachFeature (feature, layer) {
    var props = feature.properties || {},
        text = popup_property && props[ popup_property ] || popup_text;
    if (text) {
        text = L.Util.template(text, props);
        layer.bindPopup( text );
    }
}

It might be THAT easy to hack! Give it a shot if you’re keen to be the first. That should be backwards compatible, so I’ll look into adding it into the next version. Thanks!

Actually, I wouldn’t want to use L.Util.template. It throws an Error, which I think is needless. Here’s my recommended function:

var templateRe = /\{ *([\w_-]+) *\}/g;
function template(str, data) {
	return str.replace(templateRe, function (match, key) {
		var value = data[key];
		if (value === undefined) {
			return match;
		}
		return value;
	});
}

• This reply was modified 4 years, 6 months ago by bozdoz.