WordPress.org

Support

Support » Plugins and Hacks » More Smilies Plugin Modification Needed

More Smilies Plugin Modification Needed

  • The More Smilies 2.1 plugin breaks the paragraph formatting in comments. Since Matt is no longer supporting his plugin (I’ve emailed him for paid plugin support, but haven’t heard back yet), I wondered if anyone could have a look at the guts of it and tell me what needs to happen to keep it from breaking the formatting.

    I know a lot of people use this plugin, so a fix would be really beneficial to a lot of users.

    Thanks in advance!

Viewing 15 replies - 1 through 15 (of 22 total)
  • anyone have any ideas?

    whooami

    @whooami

    Member

    define “breaks the paragraph formatting”

    Be specific.

    The paragraph line break formatting is stripped. There are discussions elsewhere in the forums on this happening with other plugins, with specific solutions for those plugins but nothing yet for the more smilies plugin.

    Here’s a good description of it on this thread:
    http://wordpress.org/support/topic/118068?replies=12

    Here’s another plugin that created the same problem with a resolution:
    http://wordpress.org/support/topic/73723?replies=19

    Thanks for your help!

    I would also like this plugin to be fixed. I was just going to try this plugin, after upgrading to 2.2, but I’ve found out from a couple threads here that it is broken. I also noticed another emoticon plugin that was broken in 2.2, if I find the link again I will add it here.

    whooami

    @whooami

    Member

    Im willing to take a look but I think I need a place to download the zip from 😛 I dont see a download link on Matt’s permalink page

    matt is playing with another blogging platform and isn’t even doing his site in WP right now

    try
    http://wordpress.org/extend/plugins/more-smilies/#post-195

    whooami

    @whooami

    Member

    I was just coming back to say I found it, thanks 🙂

    whooami

    @whooami

    Member

    dgold, I notice in that other thread intricateartist mentions some filters. Ive installed 2.1 and looked through the code and I dont see any filters anywhere in the source.

    What version are you using, is it higher than 2.1?

    I’m seeing some errors, some pretty big errors, but the linebreaks are staying intact for me.

    if youre using a version above 2.1 can you email me a copy of your zip — feel free to use the email addy that I used when I sent off the thank you for the donation 🙂

    I emailed you to see if you happen to be awake and have msn messenger or something equivalent.

    I’ve got 2.1 installed, the filters are toward the top of the code in the plugin here:

    # remove filters
    		remove_filter('comment_text', 'convert_smilies', 20);
    		remove_filter('the_content', 'convert_smilies');
    		remove_filter('the_excerpt', 'convert_smilies');
    
    		# add filters
    		add_filter('comment_text', array(&$this, 'convert_smilies'));
    		add_filter('the_content', array(&$this, 'convert_smilies'));
    		add_filter('the_excerpt', array(&$this, 'convert_smilies'));

    Here’s what it’s doing to my comments, note the bold commentors name I’m responding to should be on a new line:
    http://intricateart.com/blog/archives/2007/05/26/final-scan-titto-preening/#comment-264255

    whooami

    @whooami

    Member

    I’m going to show you what I get on my FRESH 2.2 install with NO other plugins activated. The only change I have made was to one line in the WordPress core that **might** be affecting this – and I didnt make the change for that reason, I made it because it was causing me another error.

    Take a look at this:

    http://www.village-idiot.org/broke/test.gif

    the top is what I typed — the bottom is what is displayed.

    The source contains the necessary after the dizzy smilie.

    whooami

    @whooami

    Member

    intricateartist,

    you are NOT using the same plugin source that I am.

    What you pasted is NOT present in any of the files that I am using.

    if you would like to verify that, grab he plugin I am looking at from here:

    http://wordpress.org/extend/plugins/more-smilies/#post-195

    You can, also, if you like zip up whatever it is that you are using, and e-mail it off to me @ whoo AT village-idiot DOT org

    Additionally, you can also look at the plugin code here:

    http://pastebin.4programmers.net/2278

    Your test comment dropped into moderation, but I released it so you can see what happened to the formatting.

    I disable just the more smilies plugin, and the formatting returns to normal, so I don’t think it’s related to other plugins.

    I can’t see the change you made in your source – it’s displaying characters only. :/

    Thank you so much for your help!

    whooami

    @whooami

    Member

    I saw what it did in the preview.

    You’re not paying attention to the important details — you are NOT using the same plugin source that I am. I don’t know where you got your plugin, but what I am using doesn’t replicate the problem that you are seeing.

    And you wont see the change I made because I made it to a file inside the wp-includes/ dir. Im not sharing it because I havent determined tha it solves anything — since we arent using the same source code.

    I’m not sure how that happened, I just deleted all those plugin files in my version 2.1 and replaced them with the files in the same version that you grabbed, they are indeed completely different, and are now presenting a whole different problem.

    Exclamation point smiley gifs are everywhere – I’m guessing I need to rewrite my smiley config file for my personal set?

    whooami

    @whooami

    Member

    I dont have any clue what you need to do since I dont know what you were using. The only error I got was preg_replace error and that occurred after I decided to change smilies from one set to another. THAT was the error I fixed.

    I’ll keep an eye on this thread to see if dgold can lend any insight into what his specific problem is.

Viewing 15 replies - 1 through 15 (of 22 total)
  • The topic ‘More Smilies Plugin Modification Needed’ is closed to new replies.