“Modal” on Dashboard not being included properly

Resolved KZeni
(@kzeni)

1 year, 10 months ago

I have this happening on a number of sites where a bunch of empty space is included on the Dashboard above the main content of the page.

Screenshot: https://cloudup.com/ce3HxhMizbg

You can see in Inspect Element that #shortPixelProposeUpgradeShade has display:none; being assigned inline. Meanwhile, #shortPixelProposeUpgrade looks to want to use .shortpixel-hide which then isn’t actually applying any styling while it then has min-height & other inline styles which leave it displaying like what’s in the screenshot.

Also, the Inspect Element shows the modal really doesn’t have any content in it outside of some containers & a close button so I’m not sure why it’s being included on this page at all (even if hidden.)

Even though it doesn’t appear to be outright breaking things, I’d love to see this cleaned up in a future version since it does have it appear like things are broken for users in the site admin.

Viewing 10 replies - 1 through 10 (of 10 total)

Thread Starter KZeni
(@kzeni)

1 year, 10 months ago

I think this might have something to do with https://github.com/short-pixel-optimizer/shortpixel-image-optimiser/blob/b103a4f64eda8c56fe2e8620791c3c4e6279d48b/res/js/shortpixel.js#L612 having [TODO] Check where this function is called and if modal is working here. where it appears it isn’t working reliably, currently.

Plugin Author ShortPixel
(@shortpixel)

1 year, 10 months ago

Thank you for bringing this up, @kzeni!
An updated plugin version should be released in the next few days, which will also include a solution to the problem you mentioned.

Regards,
Alex

Thread Starter KZeni
(@kzeni)

1 year, 10 months ago

I appreciate the update & look forward to the next release! 🙂

Plugin Author Pedro
(@petredobrescu)

1 year, 10 months ago

hello @kzeni,

Version 5.0.2 was just released and should contain a fix for the issue you reported. Thanks a lot for reporting it!

We’re here if any other issues come up!

Thread Starter KZeni
(@kzeni)

1 year, 10 months ago

Looks to be good now. Thanks!

badknees
(@badknees)

1 year, 10 months ago

I had the same problem. Version 5.0.2 did not fix the problem.

Please advise.

Thread Starter KZeni
(@kzeni)

1 year, 10 months ago

@badknees Are you sure caching (server, browser, or both) isn’t coming into play that’s getting in the way of the 5.0.2 update from showing the fixed output?

I had numerous sites where this was happening and 5.0.2 fixed it for all of them so I’m not sure what would be different on your end.

Moderator Steven Stern (sterndata)
(@sterndata)

Volunteer Forum Moderator

1 year, 10 months ago

Moderator note:

@badknees , if you need support then per the forum guidelines please start your own topic at https://wordpress.org/support/plugin/shortpixel-image-optimiser/#new-post

https://wordpress.org/support/forum-user-guide/faq/#i-have-the-same-problem-can-i-just-reply-to-someone-elses-post-with-me-too
badknees
(@badknees)

1 year, 10 months ago
I have cleared caches, used 2 different browsers, purged CDN and disabled plugins one by one.

If I deactivate SHORTPIXEL, clear cache and then reactivate I get the “quota exceeded” dialog at the top of the dashboard. If I try to dismiss it, it does not dismiss.

However, if I refresh the browser, a bunch of empty space is included on the Dashboard above the main content of the page again and the “dismiss” dialog is gone.
- This reply was modified 1 year, 10 months ago by badknees.
Thread Starter KZeni
(@kzeni)

1 year, 10 months ago

Okay… there are 2 parts of follow-up that branch from this initial issue being resolved.

https://wordpress.org/support/topic/empty-space-is-included-on-the-dashboard-above-the-main-content-of-the-page/#post-15754419 points out how the empty space re-surfaces after the Quote Exceeded notice is dismissed.

https://wordpress.org/support/topic/quota-exceeded-notice-cannot-be-dismissed-on-dashboard/ points out how the Quota Exceeded notice being dismissed appears to do nothing due to a JS error (even though it performs some actions… it just doesn’t successfully hide the note until manually refreshing/etc.)

Viewing 10 replies - 1 through 10 (of 10 total)

The topic ‘“Modal” on Dashboard not being included properly’ is closed to new replies.