Support » Plugin: Ads.txt Manager » Missing Text Domain

  • Alex Lion

    (@alexclassroom)


    Hi,

    I found the following strings missing their text domain.

    inc\admin.php

    Line 238, 240, 242, 244, 246.

    Otherwise, the string “Save Changes” in line 134 should be able to be localizable, but it can’t be in the current version.

    If possible, please implement the about.

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Helen Hou-Sandi

    (@helen)

    4.0 and 4.7 Release Lead

    Hi there – I’m a little confused about this as inc/admin.php is only 232 lines long. That said, the “Save Changes” string was purposefully left without domain because it’s an existing string in the core admin context.

    Alex Lion

    (@alexclassroom)

    From https://developer.wordpress.org/plugins/internationalization/how-to-internationalize-your-plugin/

    If there are strings in your plugin that are also used in WordPress core (e.g. ‘Settings’), you should still add your own text domain to them, otherwise they’ll become untranslated if the core string changes (which happens).

    Plugin Author Helen Hou-Sandi

    (@helen)

    4.0 and 4.7 Release Lead

    @alexclassroom Yes, I do know that the string can change eventually and I really do appreciate your detailed attention here. In this specific case, should that core string change, I would prefer to know so we can change the plugin to match whatever core is using to say “Save Changes” (or if it moves away from save buttons entirely).

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Missing Text Domain’ is closed to new replies.