Support » Plugin: Design Approval System » Minor and Major bug IMO

  • Resolved designdrumm

    (@designdrumm)


    Hello,
    I am trying out your plugin and I really like it. However, there are a few things that are working incorrectly with it.

    First issue I have found is that when viewing a clients files in the project board, if I have another tab open and I log out of WordPress in that tab but have the other tab open with the project board being viewed, when I restart my browser (and at this point logged out of WordPress) the page comes back up with all the client details still viewable.

    This is supposed to be a login only area and I even have it set to only let users view when logged in. I am not using any caching scripts at this time either. I am using Safari 10.1.1.

    When the tab gets reloaded, it should prompt for login if they are not. Yes?

    The second thing I found was that on the project board when viewing details for a project, the clients email keeps duplicating to infinity. Eventually pushing the box off the screen. Little less than desirable. :/

    Hope you can update these fixes soon. Would like to utilize your plugin.

    Best,
    designdrumm

Viewing 15 replies - 1 through 15 (of 17 total)
  • Plugin Author slickremix

    (@slickremix)

    Thanks for contacting us and letting us know about these bugs. We’ll look into these issues and get back with you next week. Have a great Sunday!

    Spencer

    Sounds good. You as well.

    One other thing. Can you please not store clear text passwords in your plugin?
    Namely the “ads-smtp-authenticate-password”.

    Maybe use a base64_encode(mcrypt_encrypt()) with salt and a fall back of base64_encode() if mcrypt_encrypt isn’t available? I’ve seen that used before. Worked pretty well.

    Look forward to an update. Thanks!

    Best,
    desigdrumm

    designdrumm

    (@designdrumm)

    Hello,
    I have since found a fix for the user pages still being displayed on re-opened tabs. Seems it was a issue localized to Safari. I did not have any cache control set on my website yet and Safari was saving the state my page was in. Info and all. So setting a cache control fixed the issue.

    The email display issue is still prevalent and the storing of passwords in clear text. So when you get a chance to look into those, please do.

    Thanks for your time.

    Best,
    designdrumm

    Plugin Author slickremix

    (@slickremix)

    @designdrumm
    Glad you found a fix to the one issue. We will look into fix the saving password issue on Monday! Have a great rest of your weekend

    Thanks,
    Justin

    Plugin Author slickremix

    (@slickremix)

    Alright I have this in place now. Tested and works great https://codex.wordpress.org/Function_Reference/wp_hash_password

    I also have a fix in place for the repeating password. I should be pushing an update sometime today that will fix those 2 items and a few other tweaks and additions we’ve added. Keep you posted and thanks for the patience.

    Spencer

    designdrumm

    (@designdrumm)

    Perfect. Thank you Spencer and fellow co-workers.
    Look forward to your update.

    Best,
    designdrumm

    designdrumm

    (@designdrumm)

    Just realized you may be solo.
    In any case thank you.

    Best,
    designdrumm

    Plugin Author slickremix

    (@slickremix)

    Just my brother and I, hopefully we grow as time goes! Alright new update pushed let me know if you encounter any other issues.

    Spencer

    designdrumm

    (@designdrumm)

    Hey Spencer,
    Oh, ok. You guys do good work. I like this idea.
    Got the new update, thank you!

    I did get an error with mine though and the email situation hasn’t gone away and the das-smtp-authenticate-password is still clear text. I tried saving data over again. No go. Still the same clear text. I also tried deactivating and uninstalling/reinstalling. Mine may not be working because of this error, not sure.

    Here is a screen shot of the error I was getting and to show you the email situation. Mine is in the details area. Just fyi.

    http://designdrumm.com/Error-Screen-Shot-2017-06-29-at-5.46.24-PM.jpg

    designdrumm

    (@designdrumm)

    Hey Spencer,
    Looks like the error I got is pretty simple to fix.
    I edited it to check and this code works without error.

    Replace this: das-project-boards.php – line 57-66

    if(is_plugin_active('das-manager/das-manager.php')){
        if(!empty($das_manager_email) && $das_manager_client_version !== 'yes'){
            $manager_client_title = 'Manager ';
        }
        else{
            $manager_client_title = 'Client ';
        }
    }
    
    $output .= '<a href="'.get_permalink($post->ID).'" title="'.the_title_attribute('echo=0').'" target="_blank" class="project-list-link">'. $manager_client_title . get_post_meta($post->ID, 'custom_version_of_design', true).'</a></div>';

    With this:

    $manager_client_title = 'Client ';
    if(is_plugin_active('das-manager/das-manager.php')){
        if(!empty($das_manager_email) && $das_manager_client_version !== 'yes'){
            $manager_client_title = 'Manager ';
        }
    }
    
    $output .= '<a href="'.get_permalink($post->ID).'" title="'.the_title_attribute('echo=0').'" target="_blank" class="project-list-link">'. $manager_client_title . get_post_meta($post->ID, 'custom_version_of_design', true).'</a></div>';

    and the error goes away.

    HTH,
    Best,
    designdrumm

    designdrumm

    (@designdrumm)

    Found a small one. In your css.

    .pb-board-amount-per-page-wrap {}

    Should be overflow:visible; or remove overflow:hidden;

    That way if someone is using a dropdown skin like WP-Chosen, it doesn’t hide the dropdown list.

    Best,
    designdrumm

    designdrumm

    (@designdrumm)

    Hey Spencer,
    Found another one. Needle in hay stack for me, but you may be able to find more quickly. There is an unclosed div tag or an orphan </div> somewhere. The new update is breaking my layout currently. I loaded the prior version of your plugin and all works as expected.

    Best,
    designdrumm

    designdrumm

    (@designdrumm)

    Found it… I think.

    Inside das-create-new-design-post-shortcode.php – Line 172-176
    The end curly brace for //End Manager Check is in the wrong place.

    Replace this:

    <?php }} //End Manager Check
    
                            if(empty($custom_manager_approved) || empty($custom_manager_email_check)){ ?>
                                </div>
                                    <?php }?>

    With this:

    <?php }
    
                            if(empty($custom_manager_approved) || empty($custom_manager_email_check)){ ?>
                                </div>
                                    <?php }} //End Manager Check?>

    When placed there, my layout is fixed.

    HTH,
    Best,
    designdrumm

    designdrumm

    (@designdrumm)

    Also, I think in das-project-boards.php line 186 should be at line 170. For me this made it so the details were not inside the thumbnail.

    HTH,
    Best,
    designdrumm

    designdrumm

    (@designdrumm)

    Hey Spencer,
    When I went to save the client email again to remove the repeating email, I got this error.

    Notice: wp_insert_post was called incorrectly. Invalid taxonomy: 0. Please see Debugging in WordPress for more information. (This message was added in version 4.4.0.) in /designdrumm.com/html/wordpress/wp-includes/functions.php on line 4139

    DebugBar came up with this notice:

    NOTICE: wp-content/plugins/design-approval-system/includes/das-create-new-design-post-shortcode.php:91 – Undefined index: new
    require(‘wp-blog-header.php’), require_once(‘wp-includes/template-loader.php’), include(‘/themes/advertica-lite/template-userpage.php’), the_content, apply_filters(‘the_content’), WP_Hook->apply_filters, call_user_func_array, do_shortcode, preg_replace_callback, do_shortcode_tag, call_user_func, Design_Approval_System\Project_Board->frontend_design_mananger, do_shortcode, preg_replace_callback, do_shortcode_tag, call_user_func, simple_das_fep

    Also got this inside the client email input box. Very strange it output there.

    <br /><b>Notice</b>: Undefined index: new in <b>/designdrumm.com/html/wordpress/wp-content/plugins/design-approval-system/includes/das-create-new-design-post-shortcode.php</b> on line <b>91</b><br />karlos@dnbphotography.net

Viewing 15 replies - 1 through 15 (of 17 total)
  • The topic ‘Minor and Major bug IMO’ is closed to new replies.