WordPress.org

Ready to get started?Download WordPress

Forums

WP Mailto Links - Manage Email Links
[resolved] [Minibug+fix] undefined variable notice (5 posts)

  1. jrf
    Member
    Posted 2 years ago #

    Hiya,

    Love the plugin! Here's just a small headsup for the next version:

    Find line 261:
    if ( $this->options[ 'icon' ] > 0 AND ( empty( $this->options[ 'no_icon_class' ] ) OR strpos( $attrs[ 'class' ], $this->options[ 'no_icon_class' ] ) === FALSE ) AND strpos( $attrs[ 'class' ], 'mail-icon-' ) === FALSE ) {
    Replace with:
    if ( $this->options[ 'icon' ] > 0 AND ( empty( $this->options[ 'no_icon_class' ] ) OR ( isset( $attrs[ 'class' ] ) && strpos( $attrs[ 'class' ], $this->options[ 'no_icon_class' ] ) === FALSE ) ) AND ( isset( $attrs[ 'class' ] ) && strpos( $attrs[ 'class' ], 'mail-icon-' ) === FALSE ) ) {

    Hope this help! Keep up the good work.

    Smile,
    Juliette

    http://wordpress.org/extend/plugins/wp-mailto-links/

  2. jrf
    Member
    Posted 2 years ago #

    Oh and another one:

    Find line 340:
    while ( $offset < $length )
    Replace with:

    $protected = '';
    
    while ( $offset < $length )

    Hope this helps!

    Smile,
    Juliette

  3. jrf
    Member
    Posted 1 year ago #

    *bump* Both bugs are still persistent in the new 1.0 version.

  4. freelancephp
    Member
    Plugin Author

    Posted 1 year ago #

    The first was solved by adding line 242:
    $class_ori = (empty($attrs['class'])) ? '' : $attrs['class'];

    The second one will be in the next bugfix release.

    Thanks Juliette for the code review (again ;)).

  5. jrf
    Member
    Posted 1 year ago #

    Excellent! Sorry I missed line 242, just did a quick code compare, bit too quick it seems ;-)

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic