Message notice errors

  • Resolved Fernando García

    (@promostudio)


    5 years, 2 months ago

    Some more errors: Submitted message notices options above or below don’t work (always below), and also bad positioning (out of the screen), with or without fixed navbar.

    (Using GeneratePress theme and latest versions of the plugin and WP).

Viewing 6 replies - 1 through 6 (of 6 total)
  • thethemefoundry

    (@thethemefoundry)

    5 years, 2 months ago

    Hey there, @promostudio 👋

    Oh no, sorry to hear that! We tried this using GeneratePress theme just now and notices position setting works fine on our end.

    Just a little heads-up — this setting only changes the position of general notice, i.e. the one that appears above after submitting the form. It doesn’t change position of error notices related to each part if that’s what you’re after. Could that be the case?

    Would you mind uploading the screenshot of wrong notice positioning somewhere or email us at support@thethemefoundry.com? We’d love to take a closer look!

    Have a great weekend! 🙂

    Thread Starter Fernando García

    (@promostudio)

    5 years, 2 months ago

    Hello!

    No, I refer to the submitted ok message (the general notice), this container: .happyforms-message-notices.

    I am testing about 100 submissions ;-), and the “screenshot” is:

    – When option above: it scrolls to top but partially out of view if we have the WP admin bar (not very important), or totally out of view if we have a fixed top navbar (very important). (I know the difficult is calculate this heights with javascript).

    – When option below: also scrolls to top and leaves notice totally out of view.

    —–
    Other bug: Chrome browser (not tested in others) does not autocomplete email field (I think this is important).

    Thank you!

    thethemefoundry

    (@thethemefoundry)

    5 years, 2 months ago

    Thanks for the details, @promostudio!

    After poking around a bit, we can replicate odd behavior with scrolling on form submission. We’ll be sure to fix that up in a future release. Thanks for reporting that! 👍

    As it turns out, autocompletion of email address behaves like that by design. Since all inputs have unique names for increased reliability and avoiding conflicts, browsers can’t autocomplete value previously submitted through other forms most of the time.

    Let us know if we can help with anything else! 🙂

    Thread Starter Fernando García

    (@promostudio)

    5 years, 2 months ago

    I think autocomplete is important, it’s a pity, other plugins do it.

    Thread Starter Fernando García

    (@promostudio)

    5 years, 2 months ago

    Hello! Testing again latest version, the below message notice continues in bad position when there are fixed elements at the top (the wpadmin navbar or a theme fixed navbar). In javascript scroll you need to give more margin at top!

    thethemefoundry

    (@thethemefoundry)

    5 years, 2 months ago

    Hey again, @promostudio!

    There’s no way for HappyForms to precisely detect your message notice position when fixed elements are in place (it will always be slightly off, depending on your fixed elements layout). But we added a filter to let you manually tweak that! Try popping this in your functions.php:

    function make_child_form_attributes( $attrs ) {
	$attrs['data-happyforms-scroll-offset'] = -100;

	return $attrs;
}

add_filter( 'happyforms_get_form_attributes', 'make_child_form_attributes' );

    You’ll want to play with the -100 value so it matches your layout.

    Let us know how that goes!

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Message notice errors’ is closed to new replies.