Markup errors

Viewing 4 replies - 1 through 4 (of 4 total)
  • Ov3rfly

    (@ov3rfly)

    6 years, 9 months ago

    The problem appears to be in shariff.php:1132 plugin version 4.4.2

    $output .= '<span class="shariff-text"';
if ( isset( $atts['theme'] ) && 'white' === $atts['theme'] ) {
   $output .= ' style="color:' . $main_color;
}
$output .= '">' . $button_text . '</span>&nbsp;';

    Suggested fix, untested:

    $output .= '<span class="shariff-text"';
if ( isset( $atts['theme'] ) && 'white' === $atts['theme'] ) {
   $output .= ' style="color:' . $main_color . '"'; // Add quote here
}
$output .= '>' . $button_text . '</span>&nbsp;'; // Remove quote here
    Thread Starter Arnd030

    (@arnd030)

    6 years, 9 months ago

    Excellent! I think you’re right, thank you very much.
    I patched shariff.php as you suggested and the HTML errors are gone.

    So, it’s a bug? Am I the first to notice it?

    Plugin Author Jan-Peter

    (@starguide)

    6 years, 9 months ago

    Has been fixed in 4.4.3.

    Thread Starter Arnd030

    (@arnd030)

    6 years, 9 months ago

    Thanks.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Markup errors’ is closed to new replies.