Support » Plugin: JSON feed » Maintaining the JSON feed plugin

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author chrisnorthwood

    (@chrisnorthwood)

    Hi Daniel,

    I’m definitely open to accepting patches – SVN diffs are easiest for me to merge and review (it’s a shame the WordPress.org plugins repo is Subversion based, I’d love to be able to accept Github pull requests!), I’d love to see how people are using and have modified the plugin!

    (I don’t actively have a use for it myself so I’ve not kept it up-to-date with newer versions of WordPress, I’m afraid!)

    Chris

    Daniel Bachhuber

    (@danielbachhuber)

    Hand Built

    Awesome, I’ll let you know when I have a patch ready

    Daniel Bachhuber

    (@danielbachhuber)

    Hand Built

    I’ve got a few patches for you:

    1. r69507 – Apply WordPress coding standards; tabs, not spaces; proper braces
    2. r69513 – Allow the query arguments to be easily filtered by generating a new WP_Query object
    3. r69639 – Include the featured image in the feed if one exists for the post.

    If these don’t apply well for you (we have the whole plugins directory in SVN), then here’s the file with all of the changes applied:

    https://dl.dropbox.com/u/743938/json-feed.php

    Feel free to drop the comment about the wpcom filters 🙂

    I don’t think our r69507 patch will apply cleanly because it’s against our slightly modified version rather than against the canonical version. For example it includes this poor filter we added ages ago but I don’t think should be added to the official version:

    $output = apply_filters( 'json_feed_output', $output);

    It filters the whole output after each item is added. It’d be better to replace it with two filters (one for the item and one final output filter).

    I’ll throw together some updated patches.

    Plugin Author chrisnorthwood

    (@chrisnorthwood)

    Yep, as you thought 69507 doesn’t apply cleanly 🙂 If you could update it that’d be great. But other than that the other patches look great!

    Thanks,

    Hi Chris,

    Are you still interested in setting up a GitHub repo for this plugin? Even though WordPress.org uses SVN, you can do all development in git/GitHub then bring the changes to SVN later – that’s how we manage several plugins here at Automattic.

    At any rate, we recently added the ‘author’ field to json output – here is a diff with the change.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Maintaining the JSON feed plugin’ is closed to new replies.