Support » Plugin: WooCommerce Products Per Page » Love it, one tiny issue: “All products per page” vs “All products”

  • Resolved joeistoybox

    (@joeistoybox)


    I love this plugin. Surprised that it is not included with woocommerce. Anyway, so glad that you made it freely available. You rock!

    Ok, so to the tiny issue. In my dropdown, I set it to have 12 24 36 -1, and it all works beautifully, except my page displays “All products per page”, instead of being like the screenshot you have as your plugin logo that shows “All products” without the “per page”. I suppose technically, it is per page as well, but since it is only 1 page, kinda redundant. Without the “per page” on the All products, it stands out more as a totally different choice, which is what I like. I suppose I probably am the only person in the world that cares or notice, so if you can point me to a simple solution, I can change just my code to fit it to my likings, if not a simple fix, I will gladly live with the way it is.

Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Author Jeroen Sormani

    (@sormano)

    Hi,

    Glad to hear you love it 🙂

    hmm, you’re totally right, it doesn’t really make sense to have that also included..
    I’ll have to think about if/how I’d change that within the plugin itself (backwards compatibility etc), but you can change it immediately with a small code snippet:

    
    add_filter( 'wppp_ppp_text', 'wppp_custom_text', 10, 2 );
    function wppp_custom_text( $text, $value ) {
    	if ( $value == '-1' ) {
    		return 'All products';
    	}
    	return '%s products per page';
    
    }
    

    Thanks for noticing / letting me know!

    Cheers,
    Jeroen

    That snippet worked beautifully. Thank you so much for the quick response and fix. I am not sure if most people would want it to display the per page or not for the All products choice. I could see the argument to leave it the long version as well. Maybe just include this snippet in the text file and FAQ section and remind them to paste it at the end of their theme / child theme functions.php file so that it won’t get overridden during an update.
    Whichever way you go, I am happy. Thanks a million.

    Bye the way, I love your other plugin: WP Dashboard Notes.

    hi . how are you man ? that was good . i did that you said but didnt solved . i use my theme but i didnt change my result-count.php and i didnt touch it . but still have problem and when select ppp more than result, it just display ” one result ” !

    oooh excuse me . i changes result page as i needed . solved . TNX bro …

    delicado

    (@delicado)

    Thanks for this. Just downloaded; it worked right away as promised, but this was the omission I noticed immediately. The ideal solution would be to have a couple of fields in the settings allowing you to adjust the words for all and x per page (with instructions on which translation keys to use as appropriate).

    joeistoybox

    (@joeistoybox)

    +1 @delicado on that solution.

    Plugin Author Jeroen Sormani

    (@sormano)

    Thanks! I’m taking that in consideration with it 🙂

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘Love it, one tiny issue: “All products per page” vs “All products”’ is closed to new replies.