Support » Theme: Astrid » Logo resize and can’t turn off cover “overlay”

  • I don’t know what it is with themes. They are all changing the size the logo and it can’t be over ridden by css.

    And this theme has a color overlaying the cover…..its well hidden. It took me almost an hour to figure out where the hell that is. If you need to turn that off so the image you upload actually looks like its supposed to look here’s the code you need.

    .header-image:after {
      background:none;
    }

    [Moderator note: code fixed. Please wrap code in the backtick character or use the code button.]

    • This topic was modified 1 year, 8 months ago by  bdbrown.
Viewing 4 replies - 1 through 4 (of 4 total)
  • AND to fix the logo problem you need to do this.

    1. Make child theme.

    2. Copy astrid_branding function from parent and replace

    This…

    
      $site_logo = get_theme_mod('site_logo');	
      if ( function_exists( 'the_custom_logo' ) && has_custom_logo() ) {
        the_custom_logo();
      } elseif ( $site_logo ) {
    		echo '<a href="' . esc_url( home_url( '/' ) ) . '" title="' . esc_attr(get_bloginfo('name')) . '"><img class="site-logo" src="' . esc_url($site_logo) . '" alt="' . esc_attr(get_bloginfo('name')) . '" /></a>';
    

    With this….

    
      $custom_logo_id = get_theme_mod('custom_logo');	
      $custom_logo = wp_get_attachment_image_src( $custom_logo_id, 'full' );
    
      if ( $custom_logo ) {
        echo '<a href="' . esc_url( home_url( '/' ) ) . '" title="' . esc_attr(get_bloginfo('name')) . '"><img class="site-logo-override" src="' . esc_url($custom_logo[0]) . '" alt="' . esc_attr(get_bloginfo('name')) . '" /></a>';
    
    
    • This reply was modified 1 year, 8 months ago by  graftedin.

    @graftedin: Sir, with all due respect you’re missing the point of the review system. If something isn’t broken don’t just give it a bad rating because you think it should work differently.

    You’ve given 1-star ratings to 6 themes in just a few hours. If you can take the time to post ratings then perhaps you should have taken the time to ask for help if you need it or report the issue if you feel there is one. You’re showing 0 consideration for the work that developers do to provide you with free themes.

    I think you’ve been in the lofty towers of theme developing too long and don’t understand what its like trying to build sites with your themes in real world situations. This project should have taken 1 hour and took almost 5 because of this logo issue. And then your theme added the extra hassle of the overlay for the cover image.

    There is something in your theme that is forcing the size of the logo to be certain proportions. In the real world not everyone has a logo that will fit those proportions and not everyone has access to photoshop to make it fit those proportions. When I tried using some basic css to reset the max height it failed. !important failed. None of those 2 attempts to fix the size should have failed if your theme was built better.

    Then the time it took to find and fix the overlay for the cover broke the camel. You have that well hidden and probably should have an option to just turn it off…..I’ve seen themes with that option.

    The bottom line is I shouldn’t have to go through heroic efforts to make the images I upload look the way made them before I uploaded them.

    I’m not sure what the review system is for if not to rate how a theme functions in the real world. If this was truly just a bug because you missed a ; I would have submitted a support request.

    Please fix these problems and I’ll consider trying your theme again.

    I just want to mention two things here:
    1.

    None of those 2 attempts to fix the size should have failed if your theme was built better

    The theme uses the core WP logo option, at least in this regard it can’t be built better than this: https://codex.wordpress.org/Theme_Logo. As you can see there, widths and heights are specified. And the height is flexed.
    2. The overlay is defined in the stylesheet. That doesn’t make it hidden, it’s right under a title that says Header Image. Even if you don’t like it you probably understand the reason for the overlay to exist. An option to disable it would perhaps be useful.

    I’m not trying to defend the theme here because it’s a theme, it’s not custom work tailored to anybody’s needs. So yeah, it won’t be fitted for everybody and it probably can be improved but that’s a different story.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Logo resize and can’t turn off cover “overlay”’ is closed to new replies.