Title: Login redirection and errors Last modified: August 30, 2016 --- # Login redirection and errors * [scottpoulin](https://wordpress.org/support/users/scottpoulin/) * (@scottpoulin) * [10 years, 4 months ago](https://wordpress.org/support/topic/login-redirection-and-errors/) * This one really has me stumped. [http://staging.gabc-boston.org/member-directory](http://staging.gabc-boston.org/member-directory) * I’m working on a site that has a login form embedded within other stuff via the[ theme-my-login] shortcode. If you sign in successfully you get redirected to the same page, all good. * If your login fails for whatever reason, you end up at [the standard login page](http://staging.gabc-boston.org/login), which is fine, but error messages are lost. You can do a failed login here and error messages display as expected. * So the question, of course, is how do I maintain error messages as the user is being redirected? * [https://wordpress.org/plugins/theme-my-login/](https://wordpress.org/plugins/theme-my-login/) Viewing 7 replies - 1 through 7 (of 7 total) * Plugin Author [Jeff Farthing](https://wordpress.org/support/users/jfarthing84/) * (@jfarthing84) * [10 years, 4 months ago](https://wordpress.org/support/topic/login-redirection-and-errors/#post-6764262) * Interesting. The form is being posted to `/login`, but the errors don’t show. Not quite sure… * Thread Starter [scottpoulin](https://wordpress.org/support/users/scottpoulin/) * (@scottpoulin) * [10 years, 4 months ago](https://wordpress.org/support/topic/login-redirection-and-errors/#post-6764274) * Thanks for checking in Jeff! Yeah interesting is one word for it all right. * By way of further info, I’m hooking into both authenticate and login_errors in the theme’s functions.php… don’t think I’m doing anything there that would break things, but the code’s pasted below just in case. The authenticate function does set a cookie but it shouldn’t stomp on any of WP’s stuff… * The only other thing that looks odd to me at first glance is when you’re redirected to the standard login page with no error messages, the form code changes a bit–` action="/login?instance=1"` – and the hidden form field `name="instance"` has no value set. * The login_errors hook: * ``` function frame_login_errors( $error ) { return '
' . str_replace( 'ERROR: ', 'Ach du meine Güte!
', $error ) . '
'; } ``` * and authenticate: * ``` // flash a message if renewal date is close or has just passed // block login if after grace period function check_renewal( $user, $username, $password ) { // do we already have an error? if ( is_wp_error( $user ) ) { return $user; } // admins always pass if ( user_can( $user, 'activate_plugins' ) ) { // expire cookie if it exists setcookie( 'renewal_message' , '', time()-1 ); return $user; } $registered = strtotime( $user->user_registered ); $expires = strtotime( $user->user_registered . ' + ' . User_Extensions::$membership_period ); $warning = $expires - ( 60 * 60 * 24 * 30 ); $grace = strtotime( $user->user_registered . ' + ' . User_Extensions::$grace_period ); $now = time(); if ( $now > $warning and $now <= $expires ) { setcookie( 'renewal_message', 'expiring' ); return $user; } elseif ( $now > $expires and $now <= $grace ) { setcookie( 'renewal_message', 'expired' ); return $user; } elseif ( $now > $grace ) { return new WP_Error( 'membership_expired', 'Sorry, your membership to GABC appears to have expired. Please click here to renew.' ); } return $user; } ``` * Plugin Author [Jeff Farthing](https://wordpress.org/support/users/jfarthing84/) * (@jfarthing84) * [10 years, 4 months ago](https://wordpress.org/support/topic/login-redirection-and-errors/#post-6764290) * Perhaps call TML directly in the template instead of using the shortcode on the members only page: * ``` theme_my_login() ``` * Thread Starter [scottpoulin](https://wordpress.org/support/users/scottpoulin/) * (@scottpoulin) * [10 years, 4 months ago](https://wordpress.org/support/topic/login-redirection-and-errors/#post-6764302) * Would have been funny if it were that easy. I’ve isolated it, I think, to `class- theme-my-login-template.php, the get_errors()` function. In this situation, after the redirect, `$is_active` is set to `false.` I even tried setting it to `true` in the `__construct` function but it’s being overwritten somewhere between being instanced and running the `get_errors` method. * The error object is there, though, as evidenced by the terrible workaround I put in place – I’ve replaced the is_active check around line 209 with `if ( 1 == 1 or $this->is_active() ) {` but that’s obviously not a permanent solution. * The other thing I found is that although the error object is there, the instance is set to 0 rather than 1. * I’ve echoed a print_r of the $theme_my_login object into an html comment. Anything here ringing any bells? * Thanks! * Plugin Author [Jeff Farthing](https://wordpress.org/support/users/jfarthing84/) * (@jfarthing84) * [10 years, 4 months ago](https://wordpress.org/support/topic/login-redirection-and-errors/#post-6764348) * When the first form is posted, it passes an instance of “1”. However, the main instance on the login page is instance “0”. Therefore, it is not the active instance until it is passed again. What happens if you add `instance = 0`to the TML call? * Thread Starter [scottpoulin](https://wordpress.org/support/users/scottpoulin/) * (@scottpoulin) * [10 years, 3 months ago](https://wordpress.org/support/topic/login-redirection-and-errors/#post-6764357) * Thanks for pulling me back to this. That did it, sort of: * Setting instance=”0″ in the TML call, either via shortcode or the function directly, didn’t work (more on this below). So I did a little preg_replace on the returned HTML to ensure the instance *is* 0, and voila, problem solved! So thanks. * ``` $form = do_shortcode( '[theme-my-login instance="0"]' ); // ensure instance=0 $form = preg_replace( '@name="instance" value="\d+"@', 'name="instance" value="0"', $form ); ``` * So the obvious question is, why can one not force an instance number? I looked at the shortcode function in class-theme-my-login.php, and in there (line 797), I found: `wp_parse_args( $atts );` * wp_parse_args requires 2 arguments – the provided array of args and an an array of default args. Just for fun I changed it to: `$atts = wp_parse_args( $atts, array('instance' => 500) );` * … and sure enough, on a generic TML call in a template with no arguments, the instance is now set to 500. * Maybe WP changed the API for this function? Anyway unless you’ve redefined `wp_parse_args` somewhere in the code, that could be the problem… * [firelf](https://wordpress.org/support/users/firelf/) * (@firelf) * [10 years, 3 months ago](https://wordpress.org/support/topic/login-redirection-and-errors/#post-6764358) * Scott, Thanks for posting this. I’ve just been looking into the same problem. Viewing 7 replies - 1 through 7 (of 7 total) The topic ‘Login redirection and errors’ is closed to new replies. * ![](https://ps.w.org/theme-my-login/assets/icon-256x256.png?rev=1891232) * [Theme My Login](https://wordpress.org/plugins/theme-my-login/) * [Frequently Asked Questions](https://wordpress.org/plugins/theme-my-login/#faq) * [Support Threads](https://wordpress.org/support/plugin/theme-my-login/) * [Active Topics](https://wordpress.org/support/plugin/theme-my-login/active/) * [Unresolved Topics](https://wordpress.org/support/plugin/theme-my-login/unresolved/) * [Reviews](https://wordpress.org/support/plugin/theme-my-login/reviews/) * 7 replies * 3 participants * Last reply from: [firelf](https://wordpress.org/support/users/firelf/) * Last activity: [10 years, 3 months ago](https://wordpress.org/support/topic/login-redirection-and-errors/#post-6764358) * Status: not resolved