Locale aware percentage sign

  • Resolved Erdem Köse

    (@erdemkose)


    6 months, 1 week ago

    The percent sign in the savings text is not locale aware. For example, Turkish is a left-to-right language but the percent sign comes before the number.

    Could you please allow it to be configured or generate the text using locale aware methods?

    foreach (['tr_TR', 'en_US', 'ar_SA', 'ar-u-nu-latn'] as $locale) {
        $numberFormatter = new NumberFormatter($locale, NumberFormatter::PERCENT);
        echo "$locale: 0.7 => " . $numberFormatter->format(0.7) . PHP_EOL;
    }

    tr_TR: 0.7 => %70
    en_US: 0.7 => 70%
    ar_SA: 0.7 => ٧٠٪؜
    ar-u-nu-latn: 0.7 => 70‎%‎

    See: https://3v4l.org/7ksVG

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Support Herman Asrori (BSF)

    (@bsfherman)

    6 months, 1 week ago

    Hi @erdemkose,

    Thank you for bringing this to our attention. I am taking forward to our team.

    Kind regards,
    Herman 😊

    Thread Starter Erdem Köse

    (@erdemkose)

    6 months, 1 week ago

    Maybe it is better and easier to update the translation to include both You saved text and the percentage and replace the placeholder with the value. This will allow translators to put the percent sign to the correct position.

    en_US: You saved {percent}%
    tr_TR: Kazancınız %{percent}
    Plugin Support Herman Asrori (BSF)

    (@bsfherman)

    6 months, 1 week ago

    Hi @erdemkose,

    Thank you for sharing. I have brought this to our team and we will implement the similar logic in the code.

    The same thing I just mentioned in your another thread, feel free to reach out to us to get the dev version.

    Kind regards,
    Herman 😊

    Plugin Support Herman Asrori (BSF)

    (@bsfherman)

    5 months, 3 weeks ago

    Hi @erdemkose,

    The issue reported should be fixed in the latest update we released a few hours ago.

    Could you please update and confirm?

    I look forward to hearing from you.

    Kind regards,
    Herman 😊

    Thread Starter Erdem Köse

    (@erdemkose)

    5 months, 3 weeks ago

    Thank you! It is fixed in the new version.

    Plugin Support Herman Asrori (BSF)

    (@bsfherman)

    5 months, 2 weeks ago

    Hi,

    Thank you for your confirmation!

    Kind regards,
    Herman 😊

Viewing 6 replies - 1 through 6 (of 6 total)

You must be logged in to reply to this topic.