Little fix for Minized JavaScript Please!

  • Resolved raidofuwa

    (@raidofuwa)


    4 years, 6 months ago

    Hey, Thank you for your great plug-ins guys! Recently I start new web site and using your social sharing plugins. I really like it because it’s simple and doesn’t generate unnecessary request.

    But I found when I minimize JavaScript, It throws a syntax error. I’m not JS specialist or something but somehow found a quick fix.

    line 517 in sassy-social-share-public.js, add ‘;’ at the end of the bracket.

    …
    Yoolink: {
    title: “Yoolink”,
    locale: “en-US”,
    redirect_url: “//yoolink.to/addorshare?url_value=” + postUrl + “&title=” + postTitle,
    }
    line 517: }; <= here comes a semi-colon
    var heateorSssMoreSharingServicesHtml = ‘<button id=”heateor_sss_sharing_popup_close” class=”close-button separated”><img src=”‘+
    …

    I read other part of the source code and thought probably you care about minification, so I wrote this here. If you think this fix doesn’t cause any other problems please do this on next update! It makes me very happy 🙂

    By the way plugin works fine if I don’t try to minify scripts but now I’m trying to get 100% score on PageSpeed, GTMetrix, Pingdom. That’s kind of latest obsession of mine.

    The page I need help with: [log in to see the link]

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Heateor Support

    (@heateor)

    4 years, 5 months ago

    Hi there,

    Thanks for the appreciation 🙂
    Sorry for the late reply. I stumbled across your thread today. Don’t have any solution at the moment. We will fix it in the next release.

    Plugin Author Heateor Support

    (@heateor)

    4 years, 4 months ago

    The changes you suggested have been introduced in the latest version. Please update your plugin.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Little fix for Minized JavaScript Please!’ is closed to new replies.