Links in main navigation and 3rd party popup

Resolved ChrisHPZ
(@chrishpz)

5 years, 1 month ago

Hi there. I’ve been using this plugin without issue for quite some time. However, it appears external links in the main navigation won’t trigger the 3rd part popup.

In the Accounts tab of the main navigation, there’s a link called “Reorder Checks”. Clicking on it should trigger the 3rd party popup, but it doesn’t. This link hasn’t been added to the omitted domains / links list either. So I’m rather confused.

For what it’s worth, we do have UberMenu installed. But it’s doubtful it’s the source of the problem. I might be wrong though.

The page I need help with: [log in to see the link]

Viewing 15 replies - 1 through 15 (of 15 total)

Plugin Contributor jrt341
(@jrt341)

5 years, 1 month ago

Just wanted to let you know I’ve confirmed the behavior you are seeing on internal pages of your site, but the link when clicked from the homepage of your site populates the modal like it should. I’ll continue to look into this and get back to you.

Thread Starter ChrisHPZ
(@chrishpz)

5 years, 1 month ago

Thanks jrt341. Just to confirm, the 3rd party popup issue is specific to external links in the main navigation. External links in page content sections are working as expected.

Thread Starter ChrisHPZ
(@chrishpz)

5 years, 1 month ago

Hi jrt341, just checking back to see if you’re able to come up with anything. I appreciate it 🙂

Plugin Contributor jrt341
(@jrt341)

5 years, 1 month ago

I’ve determined that UberMenu is what’s causing your issue. It’s wrapping the text of your link in a span inside of the anchor tag. My plugin doesn’t account for this. I will work on getting a fix in for this since I know many people do use UberMenu. I’ll post back here once I have it fixed.

Plugin Contributor jrt341
(@jrt341)

5 years, 1 month ago

So I installed UberMenu on a dev site of mine and can’t recreate the issue. What I thought might be the problem isn’t one for me. Can you recall any changes made to your site before you started having the issue?

Thread Starter ChrisHPZ
(@chrishpz)

5 years, 1 month ago

I can’t recall any specific changes that would affect the functionality. But on another note, is there an alternative way I could trigger the 3rd party popup on the links in question? Maybe something like the following:

<a href="some-external-link" onclick="someFunction()">External Link</a>

Plugin Contributor jrt341
(@jrt341)

5 years, 1 month ago

I don’t have another way for you to trigger the popup. Have you switched themes to see if it that fixes your issue. Would you be willing to export your UberMenu settings and send them to me?

Plugin Contributor jrt341
(@jrt341)

5 years, 1 month ago

Some more information that I find interesting about your error. When going to your site in a private window in Firefox the modal pops up as expected when clicking on the link in your drop down menu. I can also see my console.log calls in the inspector as well.

When using that private window in Firefox it uses stricter content blocking by default. If I turn it off the modal stops activating and working like it should.

Did you do any changes recently with cookies or maybe some tracking added to Google Tag Manager. I’m just trying to think of what could be causing your issue.

Thread Starter ChrisHPZ
(@chrishpz)

5 years, 1 month ago

Hi JRT, this site has remained in the same state since it was launched. Below are my Ubermenu settings as taken from Ubermenu->Main UberMenu Configuration->Import/Export

{"direct_inject":"off","nav_menu_id":"6","skin":"black-white-2","orientation":"horizontal","vertical_submenu_width":"","trigger":"hover_intent","transition":"shift","transition_duration":".1s","bar_align":"left","bar_width":"","bar_margin_top":"","bar_margin_bottom":"","items_align":"left","bar_inner_center":"off","bar_inner_width":"","descriptions_top_level":"on","descriptions_headers":"on","descriptions_normal":"on","target_divider":" \u2013 ","bound_submenus":"off","submenu_inner_width":"1300px","submenu_max_height":"","dropdown_within_mega":"off","image_size":"full","image_width":"249px","image_height":"223px","image_set_dimensions":"off","image_title_attribute":"off","disable_images_mobile":"off","lazy_load_images":"off","submenu_background_image_reponsive_hide":"off","responsive":"on","responsive_toggle":"on","responsive_toggle_tag":"a","responsive_toggle_content":"Menu","responsive_collapse":"on","responsive_max_height":"","display_retractor_top":"on","display_retractor_bottom":"on","retractor_label":"","force_styles":"off","style_menu_bar_background":"","style_menu_bar_transparent":"off","style_menu_bar_border":"","style_menu_bar_radius":"","style_top_level_font_size":"15","style_top_level_text_transform":"capitalize","style_top_level_font_weight":"","style_top_level_font_color":"","style_top_level_font_color_hover":"","style_top_level_font_color_current":"","style_top_level_font_color_highlight":"","style_top_level_background_hover":"","style_top_level_background_current":"","style_top_level_background_highlight":"","style_top_level_item_divider_color":"","style_top_level_item_glow_opacity":"","style_top_level_item_glow_opacity_hover":"","style_top_level_padding":"","style_top_level_horiz_padding":"","style_extra_submenu_indicator_padding":"on","style_align_submenu_indicator":"edge","style_top_level_item_height":"","style_submenu_background_color":"","style_submenu_border_color":"","style_submenu_dropshadow_opacity":"","style_submenu_fallback_font_color":"","style_submenu_minimum_column_width":"","style_submenu_highlight_font_color":"","style_submenu_item_padding":"","style_header_font_size":"15","style_header_font_color":"","style_header_font_color_hover":"","style_header_font_color_current":"","style_header_font_weight":"normal","style_header_border_color":"","display_header_border_color":"off","style_normal_font_color":"","style_normal_font_color_hover":"","style_normal_font_color_current":"","style_normal_font_size":"14","style_normal_background_hover":"","style_flyout_vertical_padding":"","style_description_font_size":"","style_description_font_color":"","style_description_text_transform":"","style_top_level_arrow_color":"","style_submenu_arrow_color":"","style_hr":"","style_toggle_background":"","style_toggle_color":"","style_toggle_background_hover":"","style_toggle_color_hover":"","style_search_color":"","style_search_placeholder_color":"","style_search_icon_color":"","row_spacing":"","icon_width":"","icon_display":"block","google_font":"","google_font_style":"","custom_font_property":"","container_tag":"nav","allow_shortcodes_in_labels":"off","display_submenu_indicators":"on","display_submenu_close_button":"off","theme_location_instance":"0"}

Plugin Contributor jrt341
(@jrt341)

5 years, 1 month ago

Thanks for those settings. I’ll take another look. Did the plugin ever produce the popup as expected on your site or is this a recently launched site and has always had this issue as far as you know?

Thread Starter ChrisHPZ
(@chrishpz)

5 years, 1 month ago

Yeah, the popup works fine when it’s in a content area. Go to https://www.membersourcecu.org/. Click on Member Education underneath the “Featured Services” heading.
Thread Starter ChrisHPZ
(@chrishpz)

5 years, 1 month ago
I really wish there was a function I could trigger though. I could do something like the following:
```
$(document).on( '#element', 'click', function(){
runSomeFunction();
});
```
Plugin Contributor jrt341
(@jrt341)

5 years, 1 month ago

Can I get you to fill out this form so I can get in contact with you outside of this thread. I’m wanting to have you test some plugin changes without releasing an update to fix your issue.
Plugin Contributor jrt341
(@jrt341)

5 years ago
I was unable to reproduce this error using UberMenu but I was able to release an update to the plugin that allows anyone to call the trelsb_handle_links function in their own JavaScript follow.

The following code is what got the links to work the way Chris expected them to with this fix in place.
```
jQuery(document).ready(function(){
// Remove the class attributes on links in question
jQuery("#menu-item-9167 a, #menu-item-9175 a").removeAttr("class");

// Add classes such that links look like the other links
jQuery('#menu-item-9167 a, #menu-item-9175 a').addClass('ubermenu-mimic-link reorder-checks-click');

// Trigger speedbump functionality on links injected with reorder-checks-click class
jQuery('.reorder-checks-click').click(function(event) {
trelsb_handle_links(event, this)
});
});
```
Thread Starter ChrisHPZ
(@chrishpz)

5 years ago

5 star review given. Many thanks my friend

Viewing 15 replies - 1 through 15 (of 15 total)

The topic ‘Links in main navigation and 3rd party popup’ is closed to new replies.