Support » Requests and Feedback » Kses breaks comment link and smilies functionality

  • I’ve been having some problems with my comments and couldn’t for the life of me figure out what was going on, until I had it print out every filter it was applying and realized that something called kses is being used to sanitize comments HTML. The three problems I have found are:

    1. Kses does not respect html elements as defined in the $comment_allowed_tags variable
    2. Because of 1, Kses removes smilies images previously added by convert_smilies(), even if the <img> tag is included in $comment_allowed_tags (it should include them regardless)
    3. Kses does not correctly deal with s that are long enough to span more then one line. They are simply replaced with empty a tags, and the link disappears

    I’ve found the problems, but not the solutions, yet. Is there a process for submitting patches? I’d be happy to grab the latest CVS version and fix all of the problems I’m finding, if there is a method of doing so, and does anyone want to see these patches? At this point I’m just fixing things as I find them on my live installation, so it’s gonna take a bit of diffing to figure out where I’ve diverged and why.

Viewing 2 replies - 1 through 2 (of 2 total)
Viewing 2 replies - 1 through 2 (of 2 total)
  • You must be logged in to reply to this topic.