WordPress.org

Forums

WP Ajaxify Comments
[resolved] jQuery("#wpadminbar").outerHeight bug (7 posts)

  1. dedepress
    Member
    Posted 2 years ago #

    there is a jquery bug in wp-ajaxify-comments.js,

    jQuery("#wpadminbar").outerHeight();

    it will returns object with jquery > 1.8, we should set the parameter false (even though there's a default {false})

    jQuery("#wpadminbar").outerHeight(false);

    http://wordpress.org/extend/plugins/wp-ajaxify-comments/

  2. janjonas
    Member
    Plugin Author

    Posted 2 years ago #

    Hi dedepress,

    thanks for your comment. could you provide an example, where
    jQuery("#wpadminbar").outerHeight();
    returns an object?

    As far as I know outerHeight() accepts one optional (boolean) parameter that defines whether the element's margin should be included when calculating the "outer height" (see http://api.jquery.com/outerHeight/).

  3. dedepress
    Member
    Posted 2 years ago #

    in wp-ajaxify-comments.js, on line 15

    var top = WPAC._Options.popupMarginTop + jQuery("#wpadminbar").outerHeight();

    I tested it with jQuery 1.8.3 and jQuery 1.9.1, the jQuery("#wpadminbar").outerHeight() returns object and we can't get correct top value, it caused blockui message box can't appear in right place. after set paremeter false, it's work.

  4. dedepress
    Member
    Posted 2 years ago #

    another issue reported by my client,: when you post the comment, the comment gets posted perfectly but the comment you write is still in textarea#comment . I think it should be emptied after the comment posted.

  5. dedepress
    Member
    Posted 2 years ago #

    another issue:

    Uncaught ReferenceError: form is not defined, wp-ajaxify-comments.js:174

  6. janjonas
    Member
    Plugin Author

    Posted 2 years ago #

    Hi,

    I'm sorry, but I can't reproduce the outerHeight problems; see http://jsfiddle.net/9EsHg/.

    Could you send me a link to the WordPress page where all the reported problems occur?

  7. janjonas
    Member
    Plugin Author

    Posted 2 years ago #

    Problem seems to be fixed. Please feel free to reopen the thread if you need further assistance...

Topic Closed

This topic has been closed to new replies.

About this Plugin

  • WP Ajaxify Comments
  • Frequently Asked Questions
  • Support Threads
  • Reviews

About this Topic

Tags

No tags yet.