I think we’re working on this through the premium support site, but I’ll leave an answer here for any other users that come to this in forum.
I then tried to run it with approve-user (as this plugin has a much nicer approval backend section) and that sends a much nicer email but with the approve users ticked off in wp-members so I can let approve users do it’s thing it’s still sending out this blank from wordpress email. I wonder if it’ll work better if there was the option to turn emails off
It has to be one or the other. You can’t use two processes to approve users. If you’re using an outside process, then you need to not use the WP-Members process.
Then it sends out a second one saying they have been approved (even though they haven’t) and it generates the shortcodes in that email. So instead of showing the name of the site it’s just [blogname] and instead of displaying the username it’s just [username] and it’s grabbing the template for this text from the user moderation template.
The plugin’s moderated registration approval would not be going out to the user if they had not been approved through the WP-Members process. That email is only triggered by WP-Members when the user approval functions are activated.
I think the email content needs to be reviewed here. WP-Members emails can be customized, meaning you can put whatever content you want into the email. The email that is sent when the user is approved is the one in the Emails tab with the heading “Registration is Moderated, User is Approved”.
That email (1) only shows in the Emails tab if moderated registration is enabled (which in your case it should not be since you’re using something else to handle user approval) and (2) is only sent if WP-Members approval function is run. That function is not linked to any WP actions and is only run if the WP-Members user approval links are what generates the action.
The reason I mentioned that the email content needs to be looked at is if you put content into an email that says the user is approved and the email “Registration is Moderated, User is Approved” email, that doesn’t mean the user is approved. Rather, it’s a case of the email content you’ve created not matching what the process actually is.
It’s also sending it from wordpress@sitename.com which that email isn’t registered at all on the site, not even in the general settings.
wordpress@sidename.com is the default address that WP’s wp_mail() function uses to send email from.
The email address in Settings > General is where you specify the email address you want notifications sent to, not from. Setting an email address in that setting has nothing to do with wp_mail().
WP-Members offers a setting for the from address for emails that it sends. But this is only for WP-Members emails. The plugin does globally set the “from address” because it does not want to step in the way of other possible addresses that a user may want to be using on the site.
If you want a global from address for all emails coming from the site, that’s a WP issue and solution, not WP-Members. Use the wp_mail_from and wp_mail_from_name filters for that. Or better yet, set up wp_mail() to send via SMTP. It’s far more robust to do it that way and you won’t have to worry about the from name and other email header issues. There’s a brief discussion of that in the second half of this post.
