Support » Plugin: Jetpack by WordPress.com » Issue with SAVING where to show sharedaddy

Issue with SAVING where to show sharedaddy

  • Resolved Sjerp van Wouden

    (@sjerp-van-wouden)


    2 years, 11 months ago

    Hi jetpack people!

    There seems to be an issue saving Jetpack settings server-side regarding showing the sharedaddy on custom post types.

    When updating the jetpack sharedaddy options I look at the returned JSON string from the wordpress.com server. The server returns the expected value for post, page or attachment or a combination. But when a custom post type is oncluded in the update the returned JSON string does not include that post type name. The jetpack options page is then updated (probably with the JSON string) and the checkbox for the custom post type option is unchecked. The page then says “saving success” (or something like that) – probably only checking for HTTP code 200, not whether the returned JSON string contains the expected values.

    So I reckon that’s a wordpress.com server-side issue compounded (correct word?) by a front end validation issue.

    The page I linked to is of a currently in early constuction site, for the relevant post type.

    The page I need help with: [log in to see the link]

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author Jeremy Herve

    (@jeherve)

    Jetpack Mechanic 🚀

    2 years, 11 months ago

    Thanks for the report. Unfortunately I can’t seem to reproduce the issue right now; when saving sharing options for a CPT, the changes appear to stick for me:
    https://i0.wp.com/i.jeremy.hu/Screen-Recording-2017-10-05-at-09-43-PM.gif

    To confirm, you experience this issue when trying to save sharing options here?
    https://wordpress.com/sharing/buttons/

    What happens when you attempt to change those options under Settings > Sharing in your dashboard? Does it work there?

    Sjerp van Wouden

    (@sjerp-van-wouden)

    2 years, 11 months ago

    Hi Jeremy,

    Thanks for getting back to me. I’m unaware (and can’t find) the page/section in the dashboard of the site itself to change sharedaddy options; I thought that wordpress.com is the only place where one can do so.

    I understand you can’t reproduce it: I just failed to reproduce it in one of my many other WP sites. In https://sjerpbouwtsites.nl/labs/socnu/ there’s no issue showing sharedaddy on custom post types. For example https://sjerpbouwtsites.nl/labs/socnu/?agenda=lorem-ipsum.

    Let me point out: same server, same WP install. Both handmade theme’s in progress, same plugins installed. I just tried deactivating all plugins, no effect.

    So is it the theme? I just switched to twentyseventeen, declared the custom post types there, but the issue remains. So it’s not the theme either.

    Then the last thing I can think of is the way I registered the custom post type. I always use the same tool I made once upon a time, here’s the file for this site in case you’re curious: https://sjerpbouwtsites.nl/labs/nieuwland/posttypes.txt But to me, there’s nothing wrong there.

    I made a video as well: https://tinyurl.com/y87xvz87
    The videos shows the saving going wrong and the JSON response.
    Please note I say “multi sites” but I mean “multiple sites” not multisite.

    If you require any more from me, please contact.

    Sjerp van Wouden

    (@sjerp-van-wouden)

    2 years, 11 months ago

    Just in: for the options where it does work to enable them, I can’t disable them.

    Plugin Author Jeremy Herve

    (@jeherve)

    Jetpack Mechanic 🚀

    2 years, 11 months ago

    Thanks for all the extra info and the video, it’s helpful!

    I’m unaware (and can’t find) the page/section in the dashboard of the site itself to change sharedaddy options

    You should see a menu under Settings > Sharing in your wp-admin dashboard, at this URL:
    https://sjerpbouwtsites.nl/labs/nieuwland/wp-admin/options-general.php?page=sharing

    Could you try to save options there, and let me know how it goes?

    Sjerp van Wouden

    (@sjerp-van-wouden)

    2 years, 11 months ago

    Allright these jetpack options are under the general options. Never thought of that. Never to old to learn ha.

    Ok so now I can see obvious differences.
    The site (socnu) where the WordPress.com saving works properly has a correct list of post types and a correct way of saving also in wp-admin.
    The site (nieuwland) where the wordpress.com saving fails has a incomplete list of post types in the wp-admin, only listing the first 4 share options that every WP install has. Adding and removing options work here though, even though not all are present.

    So this opens up a range of thoughts to look into. Yet if I remember correctly the two different sites hook the cpts in the same action so there should be no difference there. To me this would be the most obvious reason for a difference – I suspect the wp-admin does not look in the database but rather which cpts where registered at theme load (or something like that). All assumptions that can be tested.

    Currently I’m on a holliday and I will look into this when I get back in 5 days. I’ll report my findings when I have them, any hints will be much appreciated.

    Plugin Author Jeremy Herve

    (@jeherve)

    Jetpack Mechanic 🚀

    2 years, 11 months ago

    Thanks for giving that a try. It would be interesting to try to add another Post Type and see if it shows up properly; you could for example enable Testimonials or Portfolios under Jetpack > Settings in your dashboard and see if the post types appear under Settings > Sharing.

    Let me know how it goes!

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Issue with SAVING where to show sharedaddy’ is closed to new replies.

Views