Support » Plugin: Site Reviews » Issue on form submit with V5

  • Resolved nartoof

    (@nartoof)


    Hi,

    Since your big update, I got an issue to submit a review because of the Terms toggle.
    Even if it is turned on, I got an error : This field must be accepted.

    The toggle works because the hidden checkbox is checked. But maybe there is a JS script error ?

    It happened on every website I got with your plugin…

    PS : I did run your migration tool.

    Thanks for your help πŸ™‚

    • This topic was modified 4 months, 2 weeks ago by nartoof.
    • This topic was modified 4 months, 2 weeks ago by nartoof.
Viewing 15 replies - 1 through 15 (of 18 total)
  • Plugin Author Gemini Labs

    (@geminilabs)

    I’m really sorry about that!

    The new terms toggle broke yesterday after adjusting something with the conditional checkboxes in the plugin settings shortly before release. It should be fixed in v5.0.2

    When will the updated v5.0.2 be available?

    Thread Starter nartoof

    (@nartoof)

    All right, thank you for your answer πŸ™‚
    Great job on the V5 btw !

    Plugin Author Gemini Labs

    (@geminilabs)

    It should already be available.

    Plugin Author Gemini Labs

    (@geminilabs)

    Thanks @nartoof, release days are stressful!

    Thread Starter nartoof

    (@nartoof)

    Sure it is…

    But no worries, we also got a lot of work now to update our websites ^^ (CSS class changed, deprecated hooks, shortcode updates)…

    Have a nice day anyway πŸ™‚

    Thread Starter nartoof

    (@nartoof)

    It’s all right V5.0.2 fix it ! Thanks again !

    Plugin Author Gemini Labs

    (@geminilabs)

    @nartoof Please make sure to read the Upgrade Guide (which you can access on the Site Reviews Help page) if you previously have been using any hooks or custom changes on Site Reviews. A few things have changed, but for the most part everything should be backwards compatible.

    Thread Starter nartoof

    (@nartoof)

    Yep I read it and update 5 websites using your plugin this morning. Everything works fine, no problem πŸ™‚

    The only problem I had is that you now use esc_html__ on the terms label and I used to display a link to the website privacy policy.

    But problem fixed with a filter !

    Plugin Author Gemini Labs

    (@geminilabs)

    Ah, thanks for catching that! I’ll change it back in the next update to you can add link in the terms translation.

    Thread Starter nartoof

    (@nartoof)

    Oh thanks πŸ™‚ I thought it was a security choice ! ^^

    Thread Starter nartoof

    (@nartoof)

    Because we are speaking, I remember a problem I got with your plugin when I want to defer JS on wordpress. I use this filter :

    function MSW_defer_parsing_javascript ( $url ) 
    {
    	if ( FALSE === strpos( $url, '.js' ) ) return $url;
    	if ( strpos( $url, 'jquery.js' ) ) return $url;
    	return "$url' defer ";
    }
    add_filter( 'clean_url', 'MSW_defer_parsing_javascript', 11, 1 );

    I need to add :

    if ( strpos( $url, 'site-reviews.js' ) ) return $url;

    Because your JS frontend file return 404 with this filter if I don’t add this line…

    Do you have any idea why ?

    Plugin Author Gemini Labs

    (@geminilabs)

    It’s because you are assuming that the URL is surrounded by single quotes "$url' defer ";. Site Reviews likely uses double quotes in which case it would be this: $url.'" defer ';

    With Site Reviews, there is actually an easier way to do this:

    
    add_filter('site-reviews/defer-scripts', function ($scripts) {
        $scripts[] = 'site-reviews';
        return $scripts;
    });
    Plugin Author Gemini Labs

    (@geminilabs)

    @nartoof Please update to v5.0.3

    Thread Starter nartoof

    (@nartoof)

    Thank you for the update ! It seems you worked hard since two days there is an update every 3 hours xD

    And thank you for the filter, I’ll use it to parse your JS files on frontend ! πŸ™‚

Viewing 15 replies - 1 through 15 (of 18 total)
  • You must be logged in to reply to this topic.