Support » Plugin: Simple Banner » Issue displaying banner on taxonomy pages

  • Resolved mrmadhat

    (@mrmadhat)


    Hi,

    There is an error in simple-banner.php which prevents the banner displaying on taxonomy pages.

    When on a taxonomy page and no pages have been disabled the result is this:

    
    get_option('disabled_pages_array') // ''
    get_the_ID() // false
    
    

    resulting in unexpected behaviour:

    
    $disabled_pages_array = explode(',', get_option('disabled_pages_array')); // ['']
    $disabled_on_current_page = 
    !empty($disabled_pages_array) && in_array(get_the_ID(), $disabled_pages_array);
    
Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author rpetersen29

    (@rpetersen29)

    Thanks for bringing this to my attention. I’ll have to add an array filter to that disabled pages array to remove empty values. Look out for an update tonight.

    Thread Starter mrmadhat

    (@mrmadhat)

    Thank you!

    Plugin Author rpetersen29

    (@rpetersen29)

    Version 2.9.4 should fix your issue. Please let me know if it doesn’t.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Issue displaying banner on taxonomy pages’ is closed to new replies.