Support » Theme: Basic » Is your theme hacked?

  • Resolved Nora McDougall

    (@nora-mcdougall)


    I have installed Basic on two sites. With the recent update on those sites, the sidebars are being activated before the Save is activated. And, it adds a set of social media buttons to the sidebars. This is only happening on sites with the Basic theme.

Viewing 11 replies - 1 through 11 (of 11 total)
  • Theme Author WP Puzzle

    (@wppuzzle)

    @nora-mcdougall,

    Could You more cleared write about this? What You do step by step and what You see?

    Nora McDougall

    (@nora-mcdougall)

    Thank you for your reply! After every widget in a sidebar added in a child theme, there is this code.

    <div class='social_share clearfix'><p class='socshare-title'></p>
    			<a rel="nofollow" class="psb fb" target="_blank" href="http://www.facebook.com/sharer.php?u=http://youpasteinvisualarts.com/&t=Home+Page&src=sp" title="Share in Facebook"></a>
    			<a rel="nofollow" class="psb vk" target="_blank" href="http://vkontakte.ru/share.php?url=http://youpasteinvisualarts.com/" title="Share in VK"></a>
    			<a rel="nofollow" class="psb ok" target="_blank" href="https://connect.ok.ru/offer?url=http://youpasteinvisualarts.com/&title=Home+Page" title="Share in OK"></a>
    			<a rel="nofollow" class="psb gp" target="_blank" href="https://plus.google.com/share?url=http://youpasteinvisualarts.com/"  title="Share in Google+"></a>
    			<a rel="nofollow" class="psb tw" target="_blank" href="http://twitter.com/share?url=http://youpasteinvisualarts.com/&text=Home+Page" title="Share in Twitter"></a>
    			</div></aside>	
    Nora McDougall

    (@nora-mcdougall)

    Theme Author WP Puzzle

    (@wppuzzle)

    @nora-mcdougall

    It is Basic’s social sharing buttons
    https://github.com/wppuzzle/basic/blob/master/inc/hooks.php#L132

    But… after widget? Buttons display after post content. Try check the Basic without child theme

    Here is a link: http://youpasteinvisualarts.com/forest-guardian-mask-gallery/

    This was only a problem after the theme update. The problem is now affecting the Sidebar which is a theme default.

    Theme Author WP Puzzle

    (@wppuzzle)

    @nora-mcdougall,

    It is look like your custom sidebar apply the_content filter to widgets text

    This has been a very interesting problem, which I have been documenting in my records and reporting details on Facebook and my website.

    I believe that the flow is:

    1. There is a child theme based on Basic as the parent theme.
    2. There are sidebars registered in the child theme.
    3. The Content Block plugin is installed.
    – Note that Content Blocks are a Custom Post Type, which means that the_content() would indeed be involved from the WordPress core functions.
    4. The Content Block plugin has a widget function that allows Content Blocks to be added into sidebars.

    I believe that your theme has a bug that affects the functionality of adding widgets to sidebars. At first the problem only showed up as one set of social media icons per page. But it has degraded severely, to affect all widgets in sidebars.

    Well, this is quite frustrating. One of the sites has the ability to add a widget to any sidebar completely disabled. The sidebars are visible in the dashboard. The widgets are visible in the dashboard, but the save function just doesn’t work.

    Theme Author WP Puzzle

    (@wppuzzle)

    @nora-mcdougall,

    unfortunately, the Content Blocks plugin wasn’t tested for compatibility with the Basic theme.

    I am think that we need add remove_action for Content Blocks custom post type

    if ( is_singular('conten_block') ){
        remove_action( 'the_content', 'basic_social_share_buttons', 10 );
    }

    where conten_block – it is id for custom for post type of Content Blocks plugin

    I think you are on the right track. It may be that it doesn’t work with any custom post type, whatever the plugin or custom code that created it.

    In one of my tests, I added the default WordPress Search widget to a sidebar and it added the social media icons to that widget as well. So, I’m wondering whether it’s messing with the other database records, as well. Unfortunately, I did not take a screenshot of that test.

    The fix we came up with before your last posts was
    Site 1: Go to Appearance -> Customize -> Post -> Social and chose Hide in the dropdown and check the Hide share buttons on static pages.

    Site 2: The action in Site 1 stopped the social media buttons from appearing, but the Content Blocks were broken. I hardcoded the content into the template files. In a few minutes, I have a meeting with my client to show her how to go into the template files if she needs to make changes. This is not a possibility with many clients, but she is fearless.

    Theme Author WP Puzzle

    (@wppuzzle)

    @nora-mcdougall

    try check in widget ‘Do not apply content filters’
    http://prntscr.com/lqm4lz

Viewing 11 replies - 1 through 11 (of 11 total)
  • The topic ‘Is your theme hacked?’ is closed to new replies.