Invalid CSS in custom-styles.css

  • Resolved simkog

    (@simkog)


    2 years, 7 months ago

    Hello,

    The theme generates a custom-styles.css file with the settings from the customization panel.

    If you set some option to ‘none’ or ‘-‘ the generated CSS file will contain invalid styles.

    For example:
    Set NONE for Typography > Headings > Text transform & Text decoration

    Generated file (formatted): 

    h1, h2, h3, h4, h5, h6, .site-title {
  text-decoration: ;
  text-transform: ;
  font-style: ;
  line-height: 1.2;
  letter-spacing: 0;
}

    The broswers only shows warning (“Invalid property value” in Chrome) but the user has to download these invalid lines to so it kinda bad for speed aka SEO.

    The page I need help with: [log in to see the link]

Viewing 3 replies - 1 through 3 (of 3 total)
  • vladff

    (@vladff)

    2 years, 7 months ago

    Hi,

    I don’t think we will be making any changes here. A few empty CSS props are less costly than a few PHP calls. Thank you for letting us know to investigate.

    Thread Starter simkog

    (@simkog)

    2 years, 7 months ago

    Understandable.

    wuleafulea

    (@wuleafulea)

    2 years, 7 months ago

    Hey @vladff,

    I also have a question regarding an issue with Botiga theme. As maybe you have knowledge on this. Is there an easy way to disable: “Page builder mode”.

    When you import products from CSV files, all new product pages are using this “Page builder mode” by default, so they have no proper paddings or structure. If you untick this box in meta, the problem disappears. But there are 100s of products.

    I have described the issue here: https://wordpress.org/support/topic/page-builder-mode-issue/

    I will really appreciate any feedback on this.

    Thanks!

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Invalid CSS in custom-styles.css’ is closed to new replies.