Internationalization of placeholder

  • Resolved Pipo

    (@epipo)


    5 years, 2 months ago

    Hello,

    I just wanted to say thank you, this is a great plugin :)! I have submitted some french translation to the WordPress community (hope it will help someone).

    By the way, your placeholder’s strings are missing internationalization, could you correct lines 297 and 311 in the admin-functions.php file like and lines 94 and 98 in the registrations-hidden-event-options.php like so:

    <?php _e( 'Leave blank for default', 'registrations-for-the-events-calendar' ); ?>

    I’ve also noticed a missing internationalization in registrations-event-meta.php on line 12 :

    <?php echo date_i18n( $date_format, strtotime( $event_obj->event_meta['start_date'] ) ); ?> <?php _e( 'to', 'registrations-for-the-events-calendar' ); ?>

    Thanks again!

    • This topic was modified 5 years, 2 months ago by Pipo.
    • This topic was modified 5 years, 2 months ago by Pipo.
    • This topic was modified 5 years, 2 months ago by Pipo.
Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author roundupwp

    (@roundupwp)

    5 years, 2 months ago

    Hey E. Pipo,

    That’s great! Thanks for doing that.

    And yes, I will make a note to fix these missed translations in an update.

    Thanks again,

    – Craig

    Plugin Author roundupwp

    (@roundupwp)

    5 years, 1 month ago

    Just an update. This has been corrected in version 2.4.4! The translation files themselves have not been updated but will be in the next major release.

    – Craig

    Thread Starter Pipo

    (@epipo)

    5 years, 1 month ago

    Awesome, thanks for your work!

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Internationalization of placeholder’ is closed to new replies.