Title: Instead of mysql_fetch_array() … ? Last modified: August 30, 2016 --- # Instead of mysql_fetch_array() … ? * Resolved [Statsman](https://wordpress.org/support/users/statsman/) * (@statsman) * [10 years, 7 months ago](https://wordpress.org/support/topic/instead-of-mysql_fetch_array/) * I ran into an issue with the latest update because I was using the mysql_query() function rather than $wpdb->get_results() – it kept returning an error that Access was denied (no password to get in the db) where it had always worked in the past. * I solved the issue of getting in to the database but I’m still using mysql_fetch_array()– which isn’t working for me. What should I be using instead? Right now I’m not getting any results that I can use – but I’m not failing on an error, either. Viewing 5 replies - 1 through 5 (of 5 total) * [catacaustic](https://wordpress.org/support/users/catacaustic/) * (@catacaustic) * [10 years, 7 months ago](https://wordpress.org/support/topic/instead-of-mysql_fetch_array/#post-6672353) * The best solution would be to use the `$wpdb` functions instead. There may be a reason why you’re not using them, but you haven’t said… * If you really have to use the native MySQL functions, firstly, don’t use `mysql_query()`. You should be using `mysqli_query()`. The `mysql_*` functions have been depracated for a very long time, and are something that should never be used in production code these days. * The easy way to get around these errors is to set up the MySQL connection yourself manually, and run your queries against that connection. While that will work, it really is unnessacary overhead when everything can be done through `$wpdb` anyway. * Thread Starter [Statsman](https://wordpress.org/support/users/statsman/) * (@statsman) * [10 years, 7 months ago](https://wordpress.org/support/topic/instead-of-mysql_fetch_array/#post-6672417) * I’m running the same code that has been working for about 5 years now – hence the deprecated stuff. * I don’t have any reason for using the MySQL functions (except they always worked in the past) and I’d like to bring my site up to date with the more secure $wpdb functions but I’m not entirely sure where I’m going wrong here. * I have this function: * ` function get_leagues( ) { // Returns leagues information for network admin page global $wpdb ; * $leagues_db_table = $wpdb->leagues ; if ( is_wp_error( $leagues_db_table ) ){ $leaguesQuery = $leagues_db_table->get_error_message() ; } else { $queryStr =" SELECT * FROM $leagues_db_table" ; $leagues = $wpdb->get_results( $queryStr ); if ( $leagues != null ) { return $leagues ; } else { return new WP_Error( 'Leagues Database Error', __("Could not find any leagues entered .") ) ; } } } * … which seems to work just fine. * Then I try to use the $leagues that is returned from it in this little snippet: * ` $leaguesQuery = get_leagues( ) ; if ( is_wp_error( $leaguesQuery ) ) { $error_string = $leaguesQuery->get_error_message(); echo '
< p>' . $error_string . '

'; } else { $leagues = array() ; $leagueInfo = array() ; $leagueNum = 0 ; while ( $leagueData = mysql_fetch_array( $leaguesQuery)){ ++$leagueNum ; $leagueInfo['blog_id'] = $leaguesQuery->blog_id ; $leagueInfo[' league_id'] = $leaguesQuery->league_id ; $leagueInfo['league_name'] = $leaguesQuery- >league_name ; $leagueInfo['league_short_name'] = $leaguesQuery->league_short_name; $leagueInfo['league_db_prefix'] = $leaguesQuery->league_db_prefix ; $leagueInfo[' active'] = $leaguesQuery->active ; $leagueInfo['leagues_db_version'] = $leaguesQuery- >leagues_db_version ; $leagues[$leagueNum] = $leagueInfo ; unset ( $leagueInfo);}} * … and get nothing! * I’m just a bit of a hacker trying to make my way through – there’s obviously something (obvious!) that I’m missing. * Any help would be appreciated. * Thanks * [catacaustic](https://wordpress.org/support/users/catacaustic/) * (@catacaustic) * [10 years, 7 months ago](https://wordpress.org/support/topic/instead-of-mysql_fetch_array/#post-6672419) * The first thing to do is check what your actual query is before you pass it to` $wpdb`. Something like this: * ``` $queryStr = "SELECT * FROM $leagues_db_table" ; echo "

".$queryStr."

"; ``` * Just an observation, and I coudl be wrong, but I didn’t think that the ~$wpdb` object formatted custom table names in the same way as the default WordPress ones, so when you try to call`$wpdb->leagues` I’m thinking that it’s not actually returning anything. You might need to use it like this: * `$leagues_db_table = $wpdb->prefix.'leagues' ;` * Oh, and when you post code on here you should always use the ‘code’ button above, otherwise you can easily break the formatting and make it unreadable. * Thread Starter [Statsman](https://wordpress.org/support/users/statsman/) * (@statsman) * [10 years, 7 months ago](https://wordpress.org/support/topic/instead-of-mysql_fetch_array/#post-6672478) * Good suggestion – but not where the problem is. * It was echoing the right query, so I took it a step further and did a foreach to echo the leagueID value – which it did. When I get to the next step where I’m populating my list table, that’s where I’m not getting any values. * ``` $leaguesQuery = get_leagues( ) ; foreach ( $leaguesQuery as $leagueInfo ) { echo "

".$leagueInfo->league_id."

"; } ``` * This works and echoes the info in the db. If I put the echo into the following snippet I get nothing! * ``` if ( is_wp_error( $leaguesQuery ) ) { $error_string = $leaguesQuery->get_error_message(); echo '

' . $error_string . '

'; } else { $leagues = array() ; $leagueInfo = array() ; $leagueNum = 0 ; while ( $leagueData = mysql_fetch_array( $leaguesQuery ) ) { ++$leagueNum ; $leagueInfo['blog_id'] = $leaguesQuery->blog_id ; $leagueInfo['league_id'] = $leaguesQuery->league_id ; $leagueInfo['league_name'] = $leaguesQuery->league_name ; $leagueInfo['league_short_name'] = $leaguesQuery->league_short_name ; $leagueInfo['league_db_prefix'] = $leaguesQuery->league_db_prefix ; $leagueInfo['active'] = $leaguesQuery->active ; $leagueInfo['leagues_db_version'] = $leaguesQuery->leagues_db_version ; $leagues[$leagueNum] = $leagueInfo ; unset ( $leagueInfo ) ; } } ``` * Instead of the While statement, I tried a foreach that came up with the same result. Obviously I’m not calling it right or something – but it worked just fine in September! * Thread Starter [Statsman](https://wordpress.org/support/users/statsman/) * (@statsman) * [10 years, 7 months ago](https://wordpress.org/support/topic/instead-of-mysql_fetch_array/#post-6672483) * D’oh! I see above that I’m still working with $leaguesQuery – which I’ve already assigned to $leagueData. * I went back in and changed it and it still didn’t work – but once I put it into a foreach it started working. * Thanks for your help! Viewing 5 replies - 1 through 5 (of 5 total) The topic ‘Instead of mysql_fetch_array() … ?’ is closed to new replies. * In: [Hacks](https://wordpress.org/support/forum/plugins-and-hacks/hacks/) * 5 replies * 2 participants * Last reply from: [Statsman](https://wordpress.org/support/users/statsman/) * Last activity: [10 years, 7 months ago](https://wordpress.org/support/topic/instead-of-mysql_fetch_array/#post-6672483) * Status: resolved ## Topics ### Topics with no replies ### Non-support topics ### Resolved topics ### Unresolved topics ### All topics