WordPress.org

Support

Support » Plugins and Hacks » [Resolved] Insert slide buttons do not work in Slideshow

[Resolved] Insert slide buttons do not work in Slideshow

Viewing 15 replies - 1 through 15 (of 20 total)
  • Plugin Author Stefan Boonstra

    @stefanboonstra

    Hi,

    There have been multiple people who reported that the insert buttons don’t work. I’ve been looking for a solution to this issue. In the mean time most people were able to use the insert buttons by using the Google Chrome or Mozilla Firefox browser, instead of Internet Explorer.

    Best regards,
    Stefan

    Thanks for replying so quickly, Stefan. I’ll try another browser. I’d really like to use this slideshow. Cheers!

    Hi, I’m using Firefox 3.6.28 (I’m on an old Mac OS) and the insert buttons don’t work for me either.

    Well ralphborland…I was using Firefox 3.6.17 on Linux and the buttons didn’t work with that. I swapped to a newer version of Firefox (not sure which exactly) on Windows and they worked fine!! If you’d like me to go back in there and check which version, I can… a bit later though as I’m just going out.
    Thanks for the tip, Stefan.

    Thanks RT& and thanks Stefan for the update, I had it working in Safari but now it works in my existing Firefox version too.

    Plugin Author Stefan Boonstra

    @stefanboonstra

    It’s great to hear that the new update indeed solved the issue. Thanks for letting me know RT7 and Ralph!

    tgd

    @terrydaisydesignsca

    Hi there,
    I have to say that this is the nicest, simplest slideshow plugin I’ve been able to find. If fact, I’ve just replaced the Easing Slider with this one on my live site – http://www.daisydesigns.ca. It all works beautifully on the live site. What’s odd is that the insert image button will not work on my localhost dev site (same website content). The other 2 insert buttons work fine, just not the insert image button. I’m using FF ver. 18.0.2. I have both the live and dev site running on the same browser, different tabs. I’ve tried it on Chrome with the same result. What’s really odd is that I have two different WP sites running on WAMP in tabs side by side, both have this plugin, only one of the sites slideshow image insert button does not work, the other site’s plugin is perfect. Could this be the fault? I will look at other plugin conflicts.

    tgd

    @terrydaisydesignsca

    I have determined that there is a strange conflict with Easy Digital Downloads plugin, but it seems to only be the case for this site on my localhost. The live site has both plugins working fine. I will investigate further.

    I’m the primary developer of Easy Digital Downloads.

    Are there any javascript errors shown in the console?

    tgd

    @terrydaisydesignsca

    Pippin,
    I haven’t determined yet exactly what the conflict is, and it may not necessarily be your plugin, but when I disable EDD, the insert image button does work. I am able to build the slideshow and when done, I can re-enable EDD with no ill effects. Both plugins produce what they’re meant to do. It’s possible that it’s a combination of plugins that is making this one work on a live site, but not on the dev site, as I don’t have all dev plugins activated. I will test again and check the console in FireBug. Pippin, please don’t get me wrong, I love EDD, I won’t stop using it and I will buy you a coffee, at least, one of these days.

    Plugin Author Stefan Boonstra

    @stefanboonstra

    Hi Pippin,

    The problem is that the your plugin outputs a hidden element without a closing tag, somewhere right before the ‘admin_footer’ action is done. My plugin’s image inserter popup is loaded on this action and is therefore right below your element. The browser will interpret my popup as a child of your element and will be hidden as well.

    This is the unclosed element:

    <div id="choose-download" style="display: none;">

    Closing it will probably solve the problem.

    Thanks for your clear description TGD!

    Best regards,
    Stefan

    tgd

    @terrydaisydesignsca

    Stefan, thanks for finding this. Which file and line number, in EDD did you discover this missing closing <div> tag? I’m trying to find it, but I can’t seem to. The only instance of that tag I could find, is in thickbox.php, line 91, but it does have a closing tag.

    Plugin Author Stefan Boonstra

    @stefanboonstra

    The output is generated in ‘easy-digital-downloads/includes/thickbox.php‘. After seeing this file, I suppose it’s a simple bug caused by the if-statements. If there are no downloads on the page, the closing tag is simply not output.

    If you want to fix this yourselves, you should switch lines 133 and 134 with lines 135 and 136. So instead of this:

    </div>
    		</div>
    		<?php
    		}

    It would look like this:

    <?php
    			}
    			</div>
    		</div>

    @stefan Thank you for noticing that! I’ve committed the fix for the next version: https://github.com/pippinsplugins/Easy-Digital-Downloads/commit/d9f47ea07b5b90142961ec520974cf67e24eef24

    tgd

    @terrydaisydesignsca

    Thank you Pippin and Stefan,
    Stefan, you are correct that there were no downloads created on that dev site. I will create a download there to check this, but I will apply the fix until Pippin’s update is rolled out. Two great plugins with awesome support. Thanks a ton.
    Terry.

Viewing 15 replies - 1 through 15 (of 20 total)
  • The topic ‘[Resolved] Insert slide buttons do not work in Slideshow’ is closed to new replies.