[resolved] Inline js - Issues / fixes (2 posts)

  1. ChiefAlchemist
    Posted 2 years ago #

    Hi Lester

    I'll be quick (but not trying to blunt).

    A client is using this plugin, specifically the tickcross Rating image / setting.

    In short, since you're using inline js (e.g. onmouseover) I think you're going to have to check anything that goes into those. For example, there's down vote msg was something like "It didn't work". Once that ' was added to the inline js it mucked up the js.

    I also had to some other fix in that same area. Something needed to be in quotes I think.

    I hope this helps. Let me know if you have any questions.

    p.s. If you could add some comments to your code that would be helpful to people like me. Nice plugin. Nice that it logs the details but it was somewhat not to easy to debug.


  2. Lester Chan
    Plugin Author

    Posted 2 years ago #


    Thanks for the bug report, I fixed it. You can download the latest dev version here https://github.com/lesterchan/wp-postratings/archive/master.zip

    The plugin is a little old and it is due for a rewrite and the rewrite will uses CSS instead of images to vote and proper JS instead of inline JS. I am still planning and finding time to do it. When it is re-written, it will be commented probably like my newer plugin, eg https://github.com/lesterchan/wp-draftsforfriends/blob/master/wp-draftsforfriends.php

Topic Closed

This topic has been closed to new replies.

About this Plugin

About this Topic


No tags yet.