• Resolved CrimsonRaddish

    (@crimsonraddish)


    The issue can be found here: http://stoddard.sfd.liamconrad.org
    It works with other themes: Haven’t Tried
    It works when I disable all other plugins: Haven’t Tried
    Meta Slider version: 2.0-beta4

    Issue:
    An erroneous </p><p> is being injected into the inline javascript just following the options, as seen by the following code:

    <p><script type='text/javascript'>
        var metaslider_313 = function($) {
            $('#metaslider_313').flexslider({
                slideshowSpeed:3000,
                animation:"fade",
                controlNav:false,
                directionNav:false,
                pauseOnHover:true,
                direction:"horizontal",
                reverse:false,
                animationSpeed:600,
                prevText:"<",
                nextText:">",
                easing:"linear",
                slideshow:true,
                useCSS:false
            });</p>
    <p>    };
        var timer_metaslider_313 = function() {
            var slider = !window.jQuery ? window.setTimeout(timer_metaslider_313, 100) : !jQuery.isReady ? window.setTimeout(timer_metaslider_313, 100) : metaslider_313(window.jQuery);
        };
        timer_metaslider_313();
    </script><br />

    This can be seen in the source of the site I’m currently developing at lines 161 and 162. This section corresponds with lines 276-287 of metaslider.class.php (get_inline_javascript() function), where there are no </p><p> mistakenly entered, nor any opportunity for these tags to be injected, as far as I can tell.

    If I may be able to get help with this quickly, this project is overdue. Your assistance with this is greatly appreciated.

    http://wordpress.org/extend/plugins/ml-slider/

Viewing 4 replies - 1 through 4 (of 4 total)
  • matchalabs

    (@matchalabs)

    Hi, the quick fix is to open /ml-slider/inc/slider/metaslider.class.php and remove line 281:

    $return_value .= "\n {$javascript}";

    Regards,
    Tom.

    Thread Starter CrimsonRaddish

    (@crimsonraddish)

    Thank you; I’ve commented out that line, and it works like a champ. This is, by the way, a fine plug-in, and I intend to purchase your Pro version once it’s available, and I’ve reviewed the licensing terms.

    matchalabs

    (@matchalabs)

    Hi, thanks for the encouraging words! I’m coding away like there’s no tomorrow trying to get things sorted. Really good to hear it’s working for you.

    I’ve put a fix in for the issue you reported, it’ll be in the next version.

    Regards,
    Tom.

    Don

    (@phoenixr)

    I have a question…when I follow these instructions I can not find that references text inside that file. Therefore I want my metaslider to – when clicked – open in a Fancybox which is built in to my theme.

    Any tips?

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Injected in FlexBox options’ is closed to new replies.