in Zotpress 7.3.10 sortby=dateAdded borks shortcode

  • Nate Angell

    (@ixmati)


    1 year, 7 months ago

    After upgrading Zotpress from 7.3.7 to 7.3.10, shortcodes with “sortby=dateAdded” started not loading (spinning gear), while “sortby=date” worked as expected.

    Note that in the example page listed here, I’ve adjusted the shortcode from “sortby=dateAdded” to just “sortby=date” so the page will function while the issue is investigated.

    The page I need help with: [log in to see the link]

Viewing 3 replies - 1 through 3 (of 3 total)
  • Thread Starter Nate Angell

    (@ixmati)

    1 year, 7 months ago

    Note: I have tested in 7.3.8 and 7.3.9 and it appears that this issue didn’t arise until 7.3.10.

    Thread Starter Nate Angell

    (@ixmati)

    1 year, 7 months ago

    I may have found the issue in line 633 of lib/shortcode/shortcode.functions.php:

    $zpr["sortby"] = strtolower(sanitize_text_field(wp_strip_all_tags($atts['sortby'])));

    should have “strtolower” removed as “dateAdded” requires the capitalized “A” so it becomes:

    $zpr["sortby"] = sanitize_text_field(wp_strip_all_tags($atts['sortby']));

    I will submit a PR in GitHub in case that’s helpful.

    Thread Starter Nate Angell

    (@ixmati)

    1 year, 7 months ago

    Sorry, I couldn’t find the right GitHub repo to make a PR in and I don’t speak SVN, so I hope what I added above is helpful.

    Thank you so much for your labors on this most awesome of plugins!!!

Viewing 3 replies - 1 through 3 (of 3 total)

The topic ‘in Zotpress 7.3.10 sortby=dateAdded borks shortcode’ is closed to new replies.