Hey Stephen – just FYI, I just tried installing 5.5.5 overtop of the existing one (ie, not deleting the old one, just installing the new) and every site I installed on I got the following error:
Fatal error: Cannot redeclare pta_vol_sus_plugin_action_links() (previously declared in /home/customer/www/SITEURL.org/public_html/wp-content/plugins/pta-volunteer-sign-up-sheets/pta-volunteer-sign-up-sheets.php:860) in /home/customer/www/SITEURL.org/public_html/wp-content/plugins/pta-volunteer-sign-up-sheets-5.5.5/pta-volunteer-sign-up-sheets.php on line 895
In all of the sites, it let the new plugin INSTALL, but the old plugin is also still installed and activated, so I cannot activate the new one. So in the plugin list both versions appear, but 5.5.5 is not activated. It seems that this is because the old one can’t be deactivated since there are other extensions (customizer, custom fields, etc) that prevent this, based on this statement:
Note: This plugin cannot be deactivated or deleted until the plugins that require it are deactivated or deleted.
Just putting this out there because I’m sure this is going to cause a lot of confusion to those not as familiar with WordPress.
Thanks, yes, I realized too late that GitHub appends the version number tag to the end of the source code zip file that it generates, which then causes this to be installed in a new directory in WordPress, messing things up.
I have manually uploaded the correct 5.5.5 version to GitHub to a new release, although GitHub still insists that I choose a tagged version and still generates a source code file.
Here is the correct 5.5.5 version:
https://github.com/dbarproductions/pta-volunteer-sign-up-sheets/releases/download/5.5.5/pta-volunteer-sign-up-sheets-5_5_5.zip
Unfortunately, I will have to change the GitHub plugin updater to serve updates a different way now if it’s going to add the version numbers to the end of the directory name.
Sorry for the troubles.
Hey Stephen – Got a major problem here.
I deactivated the extensions, so I would be able to deactivate the OLD sign up sheets plugin. I deactivated that, then activated the NEW 5.5.5 plugin – but the extensions all cannot be activated now because it says the required plugin is missing! See this screenshot, please:
https://prnt.sc/B97bAQKdE7ML
Ah, thanks for the updated version. Will this fix the issue with the extensions??
I installed the new version on a different site and did not have the issue that I showed in the screenshot, so that is good. When I uploaded the new 5.5.5 (fixed) version, I saw that all of the extensions are showing that there’s updates available. Does this mean that ALL I have to do is update the main SUS plugin, and not all of the other extensions, and the new updates will be available from the Admin dashboard?
Hope so – that would save a ton of time since I have so many sites with SUS and extensions. 🙂
If you have old version of the extensions, then you will need to update those individually. They are separate from the main/free plugin. You can always look at the extensions pages on my website to see what the current version is for each.
I’m also going to have to remove the github plugin updater code from version 5.5.5 since it will grab the “source code” version if I make a new release on github, which will then have the wrong directory name again. So, I’ll need to publish a 5.5.6 version without the updater code in it until I can come up with a better solution (or maybe the WP guys will fix the SVN here eventually).
In trying to fix this, I guess I just made things worse… but, I’ll get it sorted out. Will probably just end up adding my licensing system and updater that I use for my extensions, but make this a free plugin on my own site and serve updates from there the way I do from my extensions.
I will be adding code for my own licensing and updater system that I use for extensions, although this will still be a free plugin. I will make another post here when it’s ready to download from my own site, and then there shouldn’t be any issues with the way GitHub generates the source files for release. I will keep the GitHub repo open to the public so others can make contributions (including updated translation files), since I was already using GitHub for my own version control, and as a method of backup, for all of my plugins.
Sorry for any inconvenience!
Version 4.6.1 is now live on my own site and is a free purchase. A purchase is required to generate a lifetime license code, which you will need to enter in the new “License” tab on the plugin’s settings page to enable automatic updates for future releases. If you already own the Complete bundle, the license code for that will also work for the main plugin.
https://stephensherrardplugins.com/plugins/pta-volunteer-sign-up-sheets/
Version 4.6.1 is now live on my own site and is a free purchase. A purchase is required to generate a lifetime license code, which you will need to enter in the new “License” tab on the plugin’s settings page to enable automatic updates for future releases. If you already own the Complete bundle, the license code for that will also work for the main plugin.
https://stephensherrardplugins.com/plugins/pta-volunteer-sign-up-sheets/
