Support » Plugin: LH Multipart Email » Huge problem when sending multiple mails + FIX

  • ResolvedPlugin Contributor y0uri

    (@y0uri)


    Hi Pete,

    When the solution implemented in your plugin is used (same with the snippets on stackoverflow this is based on), the alternative text body is reused for different consecutive mails being sent. This results in recipients potentially receiving mails not meant for them. Luckily most people using HTML-enabled mail clients won’t see the text version, but it’s still a security problem in a way.

    I implemented your plugin on a site with Event Espresso and found that when approving a registration for an event, EE then sends multiple mails in one go. One mail notifying the event admin, and another, obviously different mail sent to the user.

    Your plugin checks, right before sending, if (1) it concerns a HTML mail and (2) if there’s no text-alternative specified. If both are yes, you provide a text alternative and let WP “hit send” on the phpmailer object.

    However, since WordPress doesn’t know you added an AltBody, on sending consecutive mails, it only clears the phpmailer properties it knows of, so it leaves the previous AltBody untouched.

    Since your plugin sees there’s an AltBody already present, it basically assumes everything’s fine and so each consecutive html mail will have the AltBody (text version) of the first mail that was sent.

    Hope you don’t mind, but I modified your plugin to fix this problem. I added extensive comments, reformatted the code and added a few filters for flexibility.

    Here’s a gist of the modified plugin, please use it as you like. I hope you decide to implement the changes so it gets pushed as an update. Thanks.

    • This topic was modified 8 months, 1 week ago by  y0uri.

    The page I need help with: [log in to see the link]

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author shawfactor

    (@shawfactor)

    Many thanks, makes sense. I´ll test and if if all okay I will push it out as version 1.10, do you want me to add you asa contributor?

    Plugin Contributor y0uri

    (@y0uri)

    Great! And sure, that’s cool, thanks.

    Plugin Author shawfactor

    (@shawfactor)

    Y0uri,
    This has been done, ie your changes and a couple of other minor one have been added, and you are now a contributor

    Pete

    Plugin Contributor y0uri

    (@y0uri)

    Cheers Pete.

    -Youri

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Huge problem when sending multiple mails + FIX’ is closed to new replies.