It looks like one of your other plugins is trying to add fees (and may be doing it in a weird way that broke with the latest update). This is where the errors are coming from: https://github.com/woocommerce/woocommerce/blob/master/includes/class-wc-cart.php#L1754-L1762
Do you know which active plugin of yours would be trying to add fees to the cart?
I am using WooCommerce Bookings & Product Add-Ons, but other than those two I can’t think of one that has anything to do with checkout or fees at all. But it’s very good to know it must be a plugin, I can goo through one by one and eliminate. I already tried deactivating Add-Ons, suspecting it was causing it, but nothing changed.
I deactivated every plugin other than WooCommerce and the error persists. I switched themes to Twenty-Seventeen as well, and the error persists. Any other thoughts?
Any customisations elsewhere, such as drop-ins folder? Has customisation been made to Twenty-Seventeen or anything?
The line in question see’s if someone has added fees the ‘old way’. $this->fees Core does not do this and i’d expect to see the issue on other sites if it wasn’t custom code on your site. If you do find the code, please share it so I can review why it errors instead of failing gracefully.
I just dug for a while a no, from what I can see it is bare-bones Twenty-Seventeen, which I leave un-edited for testing when stuff breaks. WooCommerce is the only active plugin, there are no drop-ins active.
Is there anything else I might try in the way of troubleshooting? Are there any logs I could dig into/provide here that might shed more light than WPs debug.log?
You mentioned you are running Bookings and Addons, did you test with those disabled? Like the others mentioned this has to be some code or a plugin that is using outdated calls. I’d try and disable all plugins except woocommerce and perhaps switch to a standard theme not in use like Storefront and then see if you still get the error.
Chances are that you are either running outdated extensions, which will need to be updated, or you might have some custom code running in your theme causing this.
I cannot reproduce the error with just WooCommerce and a standard theme like Twenty Seventeen or Storefront.
I went in through shell and manually removed all plugins except woocommerce, then downloaded fresh version of Storefront theme. Error is persisting as written above even in this environment. Where else could modification possibly be coming from, if not from a plugin (none others are active) or a theme (Storefront is totally vanilla)? I’m really not sure where to search from here. Could a plugin I’ve used in the past have caused a permanent issue that would endure even after it is deactivated and removed? Could custom code from the theme I normally use stick around even after the theme is changed? It must be coming from somewhere…
Are you on HHVM or PHP?
I’d try 3.2.1 when it’s out shortly. We’ve tweaked the fees deprecation code. If it doesn’t help we could try some extra debugging to see what is calling it.
HHVM. I will patiently await 3.2.1, and I really appreciate all the help so far everyone.
Actually then, since you have a HHVM install and I cannot test it, and to save me needing to do another patch release, could you test this PR?
https://github.com/woocommerce/woocommerce/pull/17193
If that works I’ll go ahead and release 3.2.1 tonight.
Mike, your new commit seems to have solved my issue. YOU’RE THE MAN!
Nice work & thank you! I’ll consider switching to PHP given WP isn’t testing with HHVM anymore (bummer).
-
This reply was modified 8 years, 8 months ago by
mattb150.
I’m going to mark this as resolved – if you have any further questions, you can start a new thread.
