HTML minify strips CSS/JS/image resources of querystring

Resolved Timothy Couckuyt
(@devplus_timo)

1 year, 3 months ago
Using the lastest version of the plugin (0.15.1).

When general browsercache and minifying are active, and JS, CSS and HTML minifying is also active, JS and CSS minified files are stripped from browsercache querystrings. Causing very unexpected results for browsers holding minified JS and CSS files in cache for as long as they can.

Filenames of minified CSS and JS files are also not refreshed when minified caches are purged or regenerated.

The only solution is to disable HTML minify’ing, which makes JS and CSS files have querystrings again.

This bug is huge and seems to be active since last year, reading these posts:
– https://wordpress.org/support/topic/query-strings-arent-being-added-to-minified-resources/
– https://wordpress.org/support/topic/query-string-not-added-to-minified-css-js/

Any ETA on a fix for this?
- This topic was modified 1 year, 3 months ago by Timothy Couckuyt.

Viewing 5 replies - 1 through 5 (of 5 total)

Plugin Contributor Marko Vasiljevic
(@vmarko)

1 year, 3 months ago

Hello @devplus_timo

I am sorry about the issue you are experiencing and I am happy to assist you with this.
The links you shared are for two different issues.
Can you please confirm the following:
1. Is the option “Prevent caching of objects after settings change ” enabled in Performance>Browser Cache?
2. Filenames should not be changed when minify is purged or regenerated. If the option “Prevent caching of objects after settings change ” enabled in Performance>Browser Cache, you should use the “Update media query string” button in BC settings or Minify settings so that the query string is changed and those files are updated in the Browser.
3. To confirm, The query string added by the mentioned option is not there if HTML minify is enabled? Have you tried using HTML tidy as HTML minifier: in Performance>General settings>Minify area?
THanks!

Thread Starter Timothy Couckuyt
(@devplus_timo)

1 year, 3 months ago

Hi @vmarko

1. Yes, it is.
2. OK, but when HTML minification is enabled, the minified JS and CSS files don’t have querystrings, that’s the issue infact. But tell me this: When is the minified filename changed? Only when contents of the minified file have changed? Or when and how does the name of the minified file get determined?
3. That’s correct! Also, with HTML tidy chosen, querystrings are indeed not stripped! That’s the desired behaviour, indeed, but why are they stripped with the default HTML minifying option?

Thanks a lot.

Thread Starter Timothy Couckuyt
(@devplus_timo)

1 year, 3 months ago

PS: To be clear, in older versions of the W3TC plugin, for example 0.9, querystrings were not stripped when using the default HTML minification option, so why is this suddenly happening?
Plugin Contributor Marko Vasiljevic
(@vmarko)

1 year, 3 months ago
Hello @devplus_timo

Thank you for the information.
2. WHen the content of the minified files is changed the Update media QUery string button comes to action as it’s generating a new query string for static assets, which tells the browser to serve a new file to the users. This is why the “Prevent caching of objects after settings change ” option is there for.
I’ve tested this and I can confirm the issue.
I’ve created a Github issue on your behalf in our repository. Please makes sure to track the progress of the issue regularly and please post a comment if you choose to do so.
Please make sure to use HTML tidy for the time being to avoid the issue.
Thank you for taking the time to report this!
- This reply was modified 1 year, 3 months ago by Marko Vasiljevic.
Thread Starter Timothy Couckuyt
(@devplus_timo)

1 year, 3 months ago

Thanks @vmarko ! I’m subscribed to the issue on GitHub.

// T

Viewing 5 replies - 1 through 5 (of 5 total)

The topic ‘HTML minify strips CSS/JS/image resources of querystring’ is closed to new replies.

Views