Support » Plugin: SAML SP Single Sign On - SSO login » Hook requests

  • Resolved benjaminniess

    (@benjaminniess)


    Hi,

    I figured out that starting from version 4.8.26 you replaced site_url function calls by site_url calls. On a classic website it does not have side effects but when using WordPress as a composer dependency it does. Would you mind to add some filters at least on ACS urls so we can change it on the fly?

    Also if you could add some “do_action” calls inside the mo_saml_login_user, we could perform custom actions while creating and loging users.

    In general, I would appreciate if you could add somme actions and filters on key features of the plugin.

    Thank you very much

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author miniOrange

    (@cyberlord92)

    Hi Benjamin,

    Thanks for using our plugin.

    I figured out that starting from version 4.8.26 you replaced site_url function calls by site_url calls.
    Could you please elaborate on this.

    Would you mind to add some filters at least on ACS URL so we can change it on the fly?
    ACS URL is dependent on the WordPress domain where the Identity Provider needs to send the response.Could you please tell us why you want to change the ACS URL?

    Also if you could add some “do_action” calls inside the mo_saml_login_user, we could perform custom actions while creating and logging users.
    Sure! we can do this.We can send an update as we add this.

    Thanks,
    miniOrange Team

    Hi,

    Thanks for your reply.

    If you take a look at the plugin in version 4.8.25, you define the home url with

    site_url()."/"

    You can find it for example in the mo_login_saml_sso_widget.php file line 127 and at several other steps in the code.

    Starting from 4.8.26, you’ve been using home_url instead of site_url.

    When you use WP as a composer dependency, most of the time, the site_url function returns an extra /wp at the end of the URL whereas the home_url does not. What I would like to have in the plugin is a get_the_acs_url function for example with a filter before returning the value so developers could fix the acs url if it’s needed.

    Thanks again and happy new year to your team!

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Hook requests’ is closed to new replies.