Support » Theme: Aaron » Highlights empty link in icon/image

  • Resolved alwaystired

    (@alwaystired)


    Currently, the links in the front page highlights icon/image are empty, causing an accessibility error when checking the page on WAVE. This issue can be solved by adding
    echo '<span class="screen-reader-text">' . wp_kses_post( get_theme_mod( 'aaron_highlight' . $i . '_headline' ) ) . '</span>';
    to /inc/highlights.php:

    
    // If there is an icon, show it unless there is also an image, then the image will replace the icon.
    if ( get_theme_mod( 'aaron_highlight' . $i . '_icon' ) && get_theme_mod( 'aaron_highlight' . $i . '_icon' ) !== 'no-icon' && ! get_theme_mod( 'aaron_highlight' . $i . '_image' ) ) {
    echo '<i aria-hidden="true" class="dashicons ' . esc_attr( get_theme_mod( 'aaron_highlight' . $i . '_icon' ) ) . '" style="color:' . esc_attr( get_theme_mod( 'aaron_highlight' . $i . '_textcolor', '#333333' ) ) . ';"></i>';
    echo '<span class="screen-reader-text">' . wp_kses_post( get_theme_mod( 'aaron_highlight' . $i . '_headline' ) ) . '</span>';
    					}
    

    If this issue can be solved in the official release it would be great!

    • This topic was modified 1 year, 2 months ago by alwaystired.
Viewing 2 replies - 1 through 2 (of 2 total)
Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Highlights empty link in icon/image’ is closed to new replies.