Plugin Author
alekv
(@alekv)
Hi Daniele
The Pixel Manager is already HPOS compatible.
Why do you think it is not?
Kind regards
Aleksandar
-
This reply was modified 1 year, 4 months ago by
alekv.
That’s good to hear, thank you. very much.
Where did I get the idea that it’s not compatible? From woocommerce itself… if I go to woocommerce -> settings -> advanced -> features , HPOS/COT cannot yet be enabled because of ‘incompatible plugins’… and this one appears in the list, so I am just looking thru that list I get on a certain production system and checking those plugins reaching out to each and every one of them to find out the truth 🙂
.i.e. <mysite>/wp-admin/plugins.php?plugin_status=incompatible_with_feature&feature_id=custom_order_tables
Maybe there is something busted with the compatibility check/declaration, then, either on the way you declared compatibility or in the way woocommerce itself checks it?
Plugin Author
alekv
(@alekv)
Maybe there is something busted with the compatibility check/declaration, then, either on the way you declared compatibility or in the way woocommerce itself checks it?
I implemented HPOS compatibility (and the declaration) before WC actually launched HPOS officially.
So there is a chance that things changed since then, or that I didn’t implement the declaration properly. I’ll look into it and will let you know once I know more.
The Pixel Manager passed all internal tests with HPOS. So I guess it’s just a small tweak I need to make.
I would not be surprised if it’s a quirk in their check or just on my system… as I refresh that page with the ‘incompatible list’ today, sometimes it returns an actual list and sometimes it doesn’t. Very weird. It might be related to some caching layer so I’d have to investigate more, too… of course it only happens on the production system and I can’t reproduce this behaviour on test environments…
Thank you again. Apologies if this was a randomization.
Plugin Author
alekv
(@alekv)
I found the issue. I implemented the declaration to only return true if HPOS is already turned on. That obviously won’t work, as the check happens when HPOS is off.
Open wgact.php
Find
if (Helpers::is_wc_hpos_enabled() && class_exists('Automattic\WooCommerce\Utilities\FeaturesUtil'))
Remove
Helpers::is_wc_hpos_enabled() &&
Then it will work.
I will publish a new version of the Pixel Manager with the fixed check soon.
No rush from this side – at least for us this is a preliminary investigation to make sure we’ll be ready to flip the switch down the road when HPOS/COT will be fully supported (we have to wait for woocommerce subscriptions too to be declared compatible, too, first)…. so right now I just started surveying the plugins that we use to get a full picture and certainly this is not some migration we would do over the christmas holidays 🙂 Take your time and thank you for all of your work.
Plugin Author
alekv
(@alekv)
@dani3l3
Today I released version 1.28.0 which contains the fixed check for HPOS compatibility.
Kind regards
Aleksandar
