Header Menu, more button on mobile

  • detering

    (@detering)


    5 years, 4 months ago

    Hello,

    Sometimes, the “more button” (class .menu-item-has-children) on mobile has a desktop behavior.
    It shows first the mobile full screen “.sub-menu” , then when I push “Back” button, it closes the mobile sub-menu and shows the desktop dropdown sub-menu.

    screens

    BR,
    Denis

Viewing 6 replies - 16 through 21 (of 21 total)
1 2
  • Andrew Nevins

    (@anevins)

    WCLDN 2018 Contributor | Volunteer support

    5 years, 4 months ago

    Thanks, don’t worry too much about the additional testing. I think that’s enough to debug the issue

    Thread Starter detering

    (@detering)

    5 years, 4 months ago

    On ipad (safari) : https://denom.be/sub-menu-issue/ipad.mp4

    On samsung (chrome) :

    https://denom.be/sub-menu-issue/samsung-s8.MOV

    Andrew Nevins

    (@anevins)

    WCLDN 2018 Contributor | Volunteer support

    5 years, 4 months ago

    I think I narrowed it down to the CSS causing the problem. There is CSS that shows the keyboard menu on hover, and, because touch devices trigger can hover events even when you aren’t using a mouse, you can be shown both the keyboard menu as well as the mobile menu.

    Andrew Nevins

    (@anevins)

    WCLDN 2018 Contributor | Volunteer support

    5 years, 4 months ago

    Bug raised on Github, thanks for your efforts.
    https://github.com/WordPress/twentynineteen/issues/731

    Thread Starter detering

    (@detering)

    5 years, 4 months ago

    Thought the same, was reading toggleSubmenuDisplay function for this.

    No problem, it’s a young theme 🙂

    Thank you and have a nice day !

    komiska

    (@komiska)

    5 years, 1 month ago

    Hi, just a heads-up: I’ve struggled with “more” button behaviour on desktop, it appeared there when it shouldn’t.
    So I dug through the files trying things out and found a TYPO!
    It’s in the “priority-menu.js” file ind the “js” folder.
    Twice.
    Line 147:

    ` // Recur if the visible list is still overflowing the nav
    if ( isOverflowingNavivation( visibleList, toggleButton, container ) ) {
    updateNavigationMenu( container );
    }
    }`

    and
    Line 123:
    if ( isOverflowingNavivation( visibleList, toggleButton, container ) ) {

    I’ve also tweeted about it, please do change the typos in the TwentyNineteen download package 🙂
    I hope that will fix all the weird behaviour. it did for me.

Viewing 6 replies - 16 through 21 (of 21 total)
1 2
  • The topic ‘Header Menu, more button on mobile’ is closed to new replies.