Having issues with it showing up properly when activated on a multi-site network

  • Resolved KZeni

    (@kzeni)


    1 year, 2 months ago

    I’m not entirely sure what might be going on, but I just tried to add this to a multi-site network where there were 7 preexisting sub-sites as a user that’s a Super Admin on top of being administrator for all sub-sites.

    However, after activation, it isn’t showing the menu item under Settings in the Network Admin.

    Instead, it’s still just adding the menu item to the Settings section for the sub-sites.

    This goes against what the plugin description says of:

    WP Htaccess Editor is fully compatible and tested with WP Network (WPMU). It shows up under the Settings menu in network admin. It’s not available in individual sites as there is only one htaccess file per network.

    https://wordpress.org/plugins/wp-htaccess-editor/

    Is this happening for anyone else, or it this something to do with this particular WordPress Network setup (somehow not having network activated plugins work as such & instead has them act like they’re individually activated on all sites)?

    That said, I have other plugins (such as Really Simple SSL, among others) that are network activated and their Network Admin settings show without issue (working like it knows it’s network activated instead of individually activated on the sub-sites.)

    Seems like this just might not working as intended & could use further testing to make sure it is (make it so network activation has the settings only show in the network admin settings & not subsite settings.)

Viewing 4 replies - 1 through 4 (of 4 total)
  • Thread Starter KZeni

    (@kzeni)

    1 year, 2 months ago

    Oh, and what’s interesting is that, to pull an example from a plugin not having this issue, https://plugins.trac.wordpress.org/browser/really-simple-ssl/trunk/class-multisite.php#L272 has something like:

    public function add_multisite_menu()
{
	if ( !is_multisite() || !rsssl_is_networkwide_active() ) {
		return;
	}
	$count = RSSSL()->admin->count_plusones();
	$update_count = $count > 0 ? "<span class='update-plugins rsssl-update-count'><span class='update-count'>$count</span></span>" : "";

	$page_hook_suffix = add_submenu_page(
		'settings.php',
		"SSL",
		"SSL".$update_count,
		'manage_security',
		"really-simple-security",
		'rsssl_settings_page'
	);
	add_action( "admin_print_scripts-{$page_hook_suffix}", 'rsssl_plugin_admin_scripts' );
}

    To specifically check for & add the multisite network’s settings page (separate from the individual site settings menu it otherwise offers if/when only activated on a per-site basis.)

    However, https://plugins.trac.wordpress.org/browser/wp-htaccess-editor/trunk/wp-htaccess-editor.php only has the one add_options_page call to add it as a standard individual site setting (while then having a bunch of options-general.php mentions throughout when a multisite network setting would need to switch to using settings.php at that point, too.)

    I’m wondering if this is something that was lost in the update to move the settings page & menu to under Settings instead of Tools & it just hasn’t popped up to be reported until now.

    It just seems odd that this really has no mention of settings.php, no use of add_submenu_page to make it added to the network admin settings menu, no mention of multisite/multi-site/network outside of Network: true in the plugin’s metadata, etc. when it appears that seems to be needed to achieve what the plugin says it’s doing for multi-site network setups.

    Thread Starter KZeni

    (@kzeni)

    1 year, 2 months ago

    *To be fair, it does still appear to work once you’re using it (with it just under the individual sites instead with them still sharing that one .htaccess file being edited.) It’s just not ideal to have the .htaccess editor option present on each of the sub-sites instead of only in the network admin given the nature of the .htaccess affecting the other sites on the network (as the plugin description touches on… just need to make sure that’s still working as intended, though.)

    Plugin Author Alexandru Tapuleasa

    (@talextech)

    1 year, 2 months ago

    Hi,

    Yes, you are right, it should be in the network menu as there is only one .htaccess file for the whole network. We will fix it in the next version 🙂

    Thread Starter KZeni

    (@kzeni)

    1 year, 2 months ago

    @talextech Thanks for the quick response, and I’ll keep an eye out for the future release. Thanks again!

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Having issues with it showing up properly when activated on a multi-site network’ is closed to new replies.