Support » Plugin: Minecraft Online Players Widget » Great plugin! but a couple of lines of bad code…I fixed it though

  • Update to review… 7/16/17

    Since it’s been over a year and the plugin hasn’t been updated I’m dropping my review.

    Original review 3/15/16
    This plugin almost nearly works perfectly, except for when there actually aren’t any players on the server…

    I found the mistakes and corrected them, may want to revise and send an update.
    I’ve commented out the area not working properly and directly below is the updated code

    In MinecraftQuery.class.php

    public function GetPlayers( )
    	{
    		//return isset( $this->Players ) ? $this->Players : false;
    		return $this->Players;
    	}

    And in widget.class.php line 54 function widget($args, $instance)

    //if($GetPlayers !== false)
    			if(!empty($GetPlayers))
    			{
    				foreach ($GetPlayers as $i => $value)
    				{
    					if($instance['displayAvatar'] !== 1)
    					{
    						$displayWidget .= '<li><img src="https://minotar.net/helm/' . $value . '/' . $instance['avatarSize'] . '.png" width="' . $instance['avatarSize'] . '" height="' . $instance['avatarSize'] . '" border="0" title="' . $value . '" alt="avatar_' . $value . '" class="avatar" />' . $value . '</li>';
    					}
    					else
    					{
    						$displayWidget .= '<li>' . $value . '</li>';
    					}
    				}
    				$resnbPlayer = count($GetPlayers);
    			}
    			else
    			{
    				$displayWidget .= '<li>' . $instance['ifNoPlayer'] . '</li>';
    				$resnbPlayer = 0;
    			}

    just make sure to change the return to $this->Players in the GetPlayers() function
    Originally what it is returning is false if there are no players and this is causing the if($GetPlayers !== false) in the widget function to pass as true since $GetPlayers was set to false you were effectively comparing if(false !== false) -> this is a true statement…

    Please take the time to update the plugin, very nice 🙂 and thank you for the time you spent on it.

    • This topic was modified 4 years, 2 months ago by aeckard87. Reason: Creator has not made the effort to update plugin despite offering correct code in review
  • The topic ‘Great plugin! but a couple of lines of bad code…I fixed it though’ is closed to new replies.