Great!

  • trickz100

    (@trickz100)


    9 years, 9 months ago

    Works great for me! Many thanks!

    One thing, however. I noticed that it only works when I’m logged in. If I was logged out, the progress bar didn’t appear at all!

    For anyone else having the problem, I worked out a fix for this:

    1) Go to the plugin folder on your server and open: “wp-pace/methods/pace-sidewide.php”

    2)

    Find (On line 23):

    if ( is_user_logged_in() ) { $loggedin = ‘.pace .pace-progress {margin-top: 32px}’; }else{ $loggedin = ”; }

    Replace:

    if ( is_user_logged_in() ) { $loggedin = ‘.pace .pace-progress {margin-top: 32px}’; }else if ( !is_user_logged_in() ){ $loggedin = ‘.pace .pace-progress {margin-top: 32px}’; }

    I hope this helps 🙂

    Once again, thanks for this great plugin!

    – Trickz100

Viewing 6 replies - 1 through 6 (of 6 total)
  • LiQuiD_FeAR

    (@liquid_fear)

    9 years, 8 months ago

    Wouldn’t that push it 32px off the top for users that aren’t logged in? I’ve had different results in different browsers. I modified css code to my liking and don’t think I experienced this.

    Thread Starter trickz100

    (@trickz100)

    9 years, 8 months ago

    No. The original code allows the progress bar to be shown only to those logged in and does not show for those who aren’t logged in.

    The ammended code is made to work for those who are logged in and for those who aren’t.

    Feel free to see the result on my website:

    http://www.unknownworld.co.uk

    LiQuiD_FeAR

    (@liquid_fear)

    9 years, 8 months ago

    What about the “sitewide” check box on the pace settings? I’m pretty sure the change you made to php, all it does it is add a margin-top so it doesn’t cover the admin bar when your logged in.

    Thread Starter trickz100

    (@trickz100)

    9 years, 8 months ago

    Yet the admin bar only shows when you’re logged in. My original post was saying that the plugin does not work for users are NOT logged in.

    I’ll break it down for you:

    Original Code:

    if ( is_user_logged_in() ) { $loggedin = ‘.pace .pace-progress {margin-top: 32px}’; }else{ $loggedin = ‘NOTICE THERE IS NOTHING HERE FOR USERS WHO ARENT LOGGED IN‘; }

    Ammended Code:

    if ( is_user_logged_in() ) { $loggedin = ‘.pace .pace-progress {margin-top: 32px}’; }else if ( !is_user_logged_in() ){ $loggedin = ‘.pace .pace-progress {margin-top: 32px}’; }

    Notice that there is now styling for those who aren’t logged in, meaning that the bar will show for them too.

    LiQuiD_FeAR

    (@liquid_fear)

    9 years, 8 months ago

    I don’t think you get it.

    This line of php pushes pace down so it doesn’t cover the admin bar when your logged in.

    if ( is_user_logged_in() ) { $loggedin = ‘.pace .pace-progress {margin-top: 32px}’; }else{ $loggedin = ”; }

    When a visitor is not logged in there is no admin bar so the code does this with out actually saying it.

    if ( is_user_logged_in() ) { $loggedin = ‘.pace .pace-progress {margin-top: 32px}’; }else{ $loggedin = ‘.pace .pace-progress {margin-top: 0px}’; }

    What you have your php doing is setting a top margin of 35px no matter if there is a admin bar present or not. I think it looks best if the pace bar is at the very top of the page.
    Check scoutingalaska.org

    Thread Starter trickz100

    (@trickz100)

    9 years, 8 months ago

    I’m well aware of what the margin style does.

    I’m not going to sit here and argue about it, all I can say is that this plugin does not work on my site for those who are not logged in without the changes I’ve made above.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Great!’ is closed to new replies.