Google Maps issues

  • Resolved Vincent VARESANO

    (@varesanodotfr)


    7 years ago

    Hi,

    I’ve two issues with The Events Calendar and Google Maps. The problem reside in the function “googleMapLink” in “Main.php”.

    First one, the parameter “hl=en” is add to the url, so Google Maps is always consider you’re english speaking. Deleting this parameter will show Google Map with visitor’s langage.

    The second issue is with the Zip code who is put after the town. So Maps don’t found it. EDIT : this issue appears when I choose “Metropolitan France” in the country list, not when I choose “France”. “Metropolitan France” isn’t necessary in the country list.

    Those two issues are easy to correct, but need to be hardcoded in “Main.php”, and the modifications are erased each time we update the plugin.

    Is someone know a way to get rid of those annoying issues without editing the file each update ?

Viewing 4 replies - 1 through 4 (of 4 total)
  • Barry

    (@barryhughes-1)

    7 years ago

    Hi @varesanodotfr,

    Great points!

    I’d highlight that the map URL is actually filterable via the tribe_events_google_map_link hook – so there’s no need to modify core plugin code to correct that one.

    not when I choose “France”. “Metropolitan France” isn’t necessary in the country list.

    To be clear, are you recommending we delete this altogether (is it not possible others would find this useful)?

    Thread Starter Vincent VARESANO

    (@varesanodotfr)

    7 years ago

    Youhou ! Thanks for the hook, that’s exactly what i’m looking for !

    To be clear, are you recommending we delete this altogether (is it not possible others would find this useful)?

    “Metropolitan France” isn’t necessary. In some rares cases some archipelago uses “France” as official country like Saint-Pierre et Miquelon, but this will not cause confusion to keep only France.

    Thanks again.

    Barry

    (@barryhughes-1)

    6 years, 11 months ago

    OK, well thanks for the feedback – I’ll make a note for us to look at making that change (re France/Metropolitan France).

    Plugin Author Victor Zarranz

    (@vicskf)

    6 years, 7 months ago

    Hi @varesanodotfr!

    Just wanted to share with you that a new maintenance release (for the Week of 18 September 2017) is out, including a fix for this issue by removing France, Metropolitan.

    Find out more about this release → https://theeventscalendar.com/maintenance-release-week-18-september-2017/

    Please update the plugins and let us know if the fix works for your site.

    Best,
    Victor

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Google Maps issues’ is closed to new replies.