Support » Plugin: Gmedia Photo Gallery » Gmedia update to V1.14.2 still does not work with php 7.2

  • Resolved edmunek

    (@edmunek)


    “V1.14.2
    Added option to disable WoowBox Banner
    Added compatibility with PHP 7.2
    Added compatibility with PHP 5.3”

    I don’t think so.
    Updated gmedia, changed php version on the server from 5.6 to 7.2 and received millions of errors wheb loading the page that gmedia couldn’t not hook because of too many arguments

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Rattus

    (@pasyuk)

    Can you post the exact errors in error_log? I’m running PHP 7.2.5 on my dev website and there are no any errors.

    : Uncaught ArgumentCountError: Too few arguments to function gmediaPermalinks::gmedia_post_thumbnail(), 2 passed in /home/blue/domains/blue.co.uk/public_html/wp-includes/class-wp-hook.php on line 286 and at least 3 expected in /home/blue/domains/blue.co.uk/public_html/wp-content/plugins/grand-media/inc/permalinks.php:242
    Stack trace:
    #0 /home/blue/domains/blue.co.uk/public_html/wp-includes/class-wp-hook.php(286): gmediaPermalinks->gmedia_post_thumbnail(‘<img class=”ada…’, 8978)
    #1 /home/blue/domains/blue.co.uk/public_html/wp-includes/plugin.php(203): WP_Hook->apply_filters(‘<img class=”ada…’, Array)
    #2 /home/blue/domains/blue.co.uk/public_html/wp-content/themes/uncode/partials/elements.php(1563): apply_filters(‘post_thumbnail_…’, ‘<img class=”ada…’, 8978)
    #3 /home/blue/domains/blue.co.uk/public_html/wp-content/themes/uncode/woocommerce/content-product.php(101): uncode_create_single_block(Arr in

    Plugin Author Rattus

    (@pasyuk)

    Seems like the problem is in your theme:
    #2 /home/blue/domains/blue.co.uk/public_html/wp-content/themes/uncode/partials/elements.php(1563): apply_filters(‘post_thumbnail_…’, ‘<img class=”ada…’, 8978)
    which override wordpress filter ‘post_thumbnail_html’ in wp-includes/post-thumbnail-template.php: line 179

    
    ...
    	/**
    	 * Filters the post thumbnail HTML.
    	 *
    	 * @since 2.9.0
    	 *
    	 * @param string       $html              The post thumbnail HTML.
    	 * @param int          $post_id           The post ID.
    	 * @param string       $post_thumbnail_id The post thumbnail ID.
    	 * @param string|array $size              The post thumbnail size. Image size or array of width and height
    	 *                                        values (in that order). Default 'post-thumbnail'.
    	 * @param string       $attr              Query string of attributes.
    	 */
    	return apply_filters( 'post_thumbnail_html', $html, $post->ID, $post_thumbnail_id, $size, $attr );

    I’ll make patch in the next plugin update, which will ignore your theme filter.

    Thank you. Will test with newer version and let you know

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Gmedia update to V1.14.2 still does not work with php 7.2’ is closed to new replies.