Functionality broken when main acf menu item hidden

  • outlandishcoop

    (@outlandishcoop)


    1 month, 2 weeks ago

    When the main acf plugin menu item is hidden (using acf/settings/show_admin hook), this plugin doesn’t load the relevant code, meaning settings can’t be saved properly, and styles aren’t loaded

    This seems to be because the enqueue_xyz functions are expecting a certain page hook name structure, which doesn’t match what’s there because the menu is hidden, and can be fixed by allowing 'admin_page_fontawesome-settings' along with the other two hook names

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Matt Keys

    (@mattkeys)

    1 month, 2 weeks ago

    I suppose the current behavior would be to hide the admin page completely if that hook is in use though wouldn’t it?

    Thread Starter outlandishcoop

    (@outlandishcoop)

    1 month, 1 week ago

    I suppose that would also be more consistent. Is there a programmatic way to set all of the options on that page? The issue I’m having is in setting the FontAwesome Kit, so that the right assets load in the backend

    Plugin Author Matt Keys

    (@mattkeys)

    1 month, 1 week ago

    Yes, check out these two filters:

    • ACFFA_fa_api_key: Filter to programmatically set the FontAwesome API key.
    • ACFFA_fa_kit_token: Filter to programmatically set the FontAwesome kit token.
    Thread Starter outlandishcoop

    (@outlandishcoop)

    1 month, 1 week ago

    Thanks, that’s done the trick!

Viewing 4 replies - 1 through 4 (of 4 total)
  • You must be logged in to reply to this topic.