Support » Plugin: Conditional Widgets » Function with Custom Post Types

Viewing 3 replies - 1 through 3 (of 3 total)
  • > I was wondering if I submitted a pull request with changes to accommodate custom types whether you would accept it

    I would certainly review it – but I can’t promise to accept it.

    There are a few reasons I’ve been hesitant to do too much with Custom Post Type integration on the plugin, and the fact that the control panel for each widget is already pretty substantial – adding logic for every CPT would grow it significantly.

    Additionally, many CPTs are used for things that don’t necessarily make sense with displaying widgets.

    Keep in mind that working with Custom Post Types typically also includes working with Custom Taxonomies as well, adding more and more to the form.

    I’m happy to take a look at a pull request, or discuss your potential implementation further. Thanks for your interest.

    Thanks for your time in responding to my query. I realize that plugin maintainer is probably the most thankless job on the planet. I wasn’t thinking that I would tackle custom taxonomies and let the next guy take that part on. I’ve never worked with them, so don’t know about all of the nuances, though could certainly take a stab at it if you think its important.

    I certainly understand your concern about the size of the control panel and totally agree that sometimes CPTs are created but never displayed as their own page. That said, at the current time all widgets are displayed on all custom post types by default whether using your plugin or not.

    To address the concern about the size of the control panel, we could also make the section headers toggle their respective sections same as the toggle to display the control panel in the first place. I’d be happy to put in a separate PR just for that functionality if you’d like.

    Definitely want to get some idea of what parameters you are looking for before diving in. I realize that even if I meet those parameters that there may be something that prevents you from accepting my PR. Just want to make sure I’m not creating something that you will reject out right.

    Looking for this as well. While I prefer this plugin to others, I’ve actually had to use others for that exact missing functionality in certain client sites.

    I’d also be game to help debug and feature scope this.

    Thanks for the great plugin none-the-less.

    • This reply was modified 4 years, 3 months ago by stilfx.
Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Function with Custom Post Types’ is closed to new replies.