Support » Plugin: MapPress Maps for WordPress » fr_FR not loading correctly in MapPress 2.56.11

  • Hi,

    First off, I want to say how I appreciate your work. I love how MapPress now integrates seamlessly with the new Gutenberg editor.

    Unfortunately, the French translation (fr_FR) doesn’t kick in anymore since I updated, despite all the translation files being clearly present in wp-content/plugins/mappress-google-maps-for-wordpress/languages/.

    I’m running WordPress 5.6 in Multisite mode. I’ve tried on older install of WordPress (5.4.4) in Multisite mode and I have the same behaviour as well. I just whipped up a brand new 5.6 basic (one site) install and I have the same behaviour too. Basically even though the site is in the fr_FR locale, the strings relating to MapPress all remain in English.

    For example, if I insert a new MapPress block, I still read “Create a new map or choose one from the map library.”, “New Map” and “Map Library” even though MapPress seem to provide a French translation for those. Would you have an idea of what could be causing the issue?

    If I find something in the meantime I’ll let you know.

    Thank you for this great plugin,

    François

Viewing 15 replies - 1 through 15 (of 16 total)
  • Plugin Author chrisvrichardson

    (@chrisvrichardson)

    Hi,

    Sorry for my slow reply, I’ve been hard at work on new features for version 2.58. I wanted to let you know I saw your note and I haven’t forgotten you, but I don’t have an answer yet.

    It looks like maybe the online translation here is missing the text references from the JavaScript files.

    User Bonaldi is the administrator of that translation, and is very knowledgeable about translation in general. You can try reaching out to him to see if he knows how this happened. I’ll keep looking into it as well – hopefully it will be a simple fix.

    Thanks for your patience.

    -Chris

    Plugin Author chrisvrichardson

    (@chrisvrichardson)

    Hi,

    I just published 2.57.1, which should allow for the JS translations to be loaded. I think for some of the strings (such as ‘map library’), the online translation at translate.wordpress.org will also need to be updated before they’ll display.

    Hopefully the update will work for you – the process for generating these translations has become ridiculously complex!

    If you have any other questions, please feel free to contact me directly.

    Thread Starter François Moreau

    (@moreauf)

    I’ve made the update to 2.57.1. It has made some translations appear (New Map –> Nouvelle carte), but some others still don’t despite being ready in translate.wordpress.org (Map Library –> Cartothèque). Is it just a matter of time for it to propagate or is there something I can do to refresh my installation?

    I agree that translating has become super tricky. I’ll have to understand this process better myself for my own work.

    Thank you very much for your reply!

    Hi Chris, it’s been a long time 😉

    What I see with version 2.57.1 :

    There is a problem with the .json file (mappress-google-maps-for-wordpress-fr_FR-4cfebd0e75a430fc3eb311e0637a25c6) in the languages folder of the plugin which is not fully translated, although I have the translations 100% on translate.

    Did you translate this file manually Chris?

    If yes, you have to generate the .json from the .po exported from translate fully translated and you have to keep the text-domain in your code strings.
    __('Map Library', 'mappress-google-maps-for-wordpress')

    Regards.

    Plugin Author chrisvrichardson

    (@chrisvrichardson)

    Hi Bonaldi,

    It’s nice to hear from you, and sorry for the trouble!

    You are correct, I generated the .json from an old .PO file. I thought the .json files would be ignored, and re-created when uploading to translate.wordpress.org.

    With that in mind –

    Should I re-generate the .json file from the translated .PO as you suggest, or just delete it and re-upload the plugin? I’m thinking if I delete the file, it will be generated again automatically when the plugin is uploaded to translate.wordpress.org. Is that correct?

    The .json has just been regenerated on translate.
    You can download it and copy it into the plugin languages folder.
    But if you don’t have the text-domain in your code, the translation won’t work.

    Plugin Author chrisvrichardson

    (@chrisvrichardson)

    I’ve removed the .json files from the plugin directory, which should allow WP to default to the files from translate.wordpress.org. Hopefully that resolves the issue.

    Hi Chris,

    This is a partial solution: translations cannot be done without text-domain.
    You have to reintegrate the text-domain in all the translatable strings of your code.
    Not __('Map Library)
    But __('Map Library', 'maps-google-maps-for-wordpress')

    You could also take the opportunity to shorten this text-domain for readability, for example : __('Map Library', 'mpgmfw')

    I made this hack on my sites, it works.

    I hope this will help.
    Regards.

    Plugin Author chrisvrichardson

    (@chrisvrichardson)

    Hi,

    Thanks, it looks like the ‘add-textdomain’ step in my build process wasn’t working. I’ve published 2.57.3 which should contain the proper text domain.

    Thread Starter François Moreau

    (@moreauf)

    Hi Chris,

    It works! It’s all translated now.

    Merci beaucoup (thank you very much)!

    François

    Plugin Author chrisvrichardson

    (@chrisvrichardson)

    Finally! I’m glad it’s working, and thanks for letting me know.

    2.57.3 not yet published at this time, on my side.

    Thread Starter François Moreau

    (@moreauf)

    Oh! Bonaldi is right. I didn’t realize it at first because I had fiddled with some files and I had decided to just uninstall and reinstall MapPress. WordPress reports that I have MapPress 2.57.2 installed, but the translations do work here now though.

    Plugin Author chrisvrichardson

    (@chrisvrichardson)

    My mistake, I didn’t bump the version number. 2.57.3 should be there now.

    C’est bon, @moreauf .
    Everything is Ok for translations now.
    Good cooperation guys. 😉

Viewing 15 replies - 1 through 15 (of 16 total)
  • You must be logged in to reply to this topic.